Commit 2da9142
## What
Adds a docstring to the `Domain` enum in `config_types.py` — a one-line
description per value with a recognizable example benchmark, plus
guidance to **pick the most specific domain** and use `other` only as a
catch-all (addresses the
[#600](#600) 'agent is too
broad / no guidance' concern **without** redefining the taxonomy).
```
math — mathematical problem solving (e.g. AIME, MATH, GSM8K).
coding — code generation, repair, or execution (e.g. SWE-bench, LiveCodeBench).
agent — multi-step, tool-using tasks (e.g. tau2, workplace_assistant). Prefer a more specific value when it fits.
... (knowledge, instruction_following, long_context, safety, games, translation, e2e, rlhf, other)
```
## Why
Epic [#1205](#1205) friction 9
(naming confusion). Surfaces on IDE hover and when reading
`config_types`; complements the inline `domain` comment added in #1597.
## Tests
`test_domain_enum_documents_every_value` asserts every `Domain` value
appears in the docstring, so a newly-added domain can't ship
undocumented.
---------
Signed-off-by: Wojciech Prazuch <wprazuch@nvidia.com>
Signed-off-by: Rita Fernandes Neves <rfernandesne@nvidia.com>
1 parent a567232 commit 2da9142
2 files changed
Lines changed: 31 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
406 | 406 | | |
407 | 407 | | |
408 | 408 | | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
409 | 430 | | |
410 | 431 | | |
411 | 432 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
0 commit comments