-
Notifications
You must be signed in to change notification settings - Fork 226
Gym CLI refactor #1630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gym CLI refactor #1630
Changes from all commits
0b159e3
7cdcb8e
cba678a
82e3505
b075b92
95ddd2f
0519f87
e013525
6a79259
bed6576
4a05371
17b79ae
6288170
6a2cd5c
16431a6
02967e0
81fca19
ba6dc10
c53e912
4b97e8a
c0747bd
efed901
8d72078
26be13d
f83f70a
a4c13b0
628086e
89c2009
dd821a1
7549fe7
68d5fb6
e1f416e
ac9e791
46a8f0e
993bf7e
534ea80
82a7835
e150edd
4deeb4f
e552e3a
34b57f1
7e1525f
14a790c
2775550
5067752
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -546,7 +546,7 @@ Externalize system prompts to text files, pass via `--system-prompt` argument. M | |
|
|
||
| ### `data/.gitignore` default patterns | ||
|
|
||
| Generated by `ng_init_resources_server`: | ||
| Generated by `gym env init`: | ||
| ``` | ||
| *train.jsonl | ||
| *validation.jsonl | ||
|
|
@@ -562,10 +562,10 @@ If your filename doesn't match (e.g. `my_eval.jsonl`), add a custom pattern (e.g | |
| 1. **Generate** the JSONL file using your conversion script (in the source repo) | ||
| 2. **Upload** to GitLab dataset registry: | ||
| ```bash | ||
| ng_upload_dataset_to_gitlab \ | ||
| +dataset_name=my_benchmark \ | ||
| +version=0.0.1 \ | ||
| +input_jsonl_fpath=resources_servers/my_benchmark/data/my_dataset.jsonl | ||
| gym dataset upload --storage gitlab \ | ||
| --name my_benchmark \ | ||
| --revision 0.0.1 \ | ||
| --input resources_servers/my_benchmark/data/my_dataset.jsonl | ||
| ``` | ||
| 3. **Add `gitlab_identifier`** to the dataset entry in YAML config: | ||
| ```yaml | ||
|
|
@@ -591,18 +591,22 @@ mlflow_tracking_token: <your-gitlab-api-token> | |
|
|
||
| The tracking URI format is `https://<gitlab-host>/api/v4/projects/<PROJECT_ID>/ml/mlflow`. | ||
|
|
||
| ### Verification with `ng_prepare_data` | ||
| ### Verification with `gym dataset collate` | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. dumb comment that i can probably answer myself, but why is it named 'collate' ?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because calling it "prepare" is misleading. It was raised in some other epic I got assigned to (it's on hold now) so I decided to try to come up with other name since I'm reinventing the commands anyways |
||
|
|
||
| Validate example data (for PR submission): | ||
| ```bash | ||
| ng_prepare_data "+config_paths=[resources_servers/my_benchmark/configs/my_benchmark.yaml]" \ | ||
| +output_dirpath=/tmp/prepare +mode=example_validation | ||
| gym dataset collate --config resources_servers/my_benchmark/configs/my_benchmark.yaml \ | ||
| --output-dir /tmp/prepare \ | ||
| --mode example_validation | ||
| ``` | ||
|
|
||
| Download and prepare train/validation from GitLab: | ||
| ```bash | ||
| ng_prepare_data "+config_paths=[resources_servers/my_benchmark/configs/my_benchmark.yaml]" \ | ||
| +output_dirpath=data/my_benchmark +mode=train_preparation +should_download=true +data_source=gitlab | ||
| gym dataset collate --config resources_servers/my_benchmark/configs/my_benchmark.yaml \ | ||
| --output-dir data/my_benchmark \ | ||
| --mode train_preparation \ | ||
| --download \ | ||
| +data_source=gitlab | ||
| ``` | ||
|
|
||
| --- | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gym env run
gym eval run
i will surely be confused by these
i would vote for rather
gym run
gym eval
or
gym start
gym run
just my 2 cents.
also, i wish entrypoint was ng not gym
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this will put the commands "outside" of their env and eval groups. What about:
gym env start
gym eval run
?
Btw, there is ng alias too! I totally forgot to document it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed
gym env run->gym env startin 993bf7e, let me know if this is good enough.