Skip to content

Commit cd8c4fb

Browse files
authored
Set default for share_embeddings_and_output_weights (#4569)
Signed-off-by: chochowski <mchochowski@nvidia.com>
1 parent 55dd9a4 commit cd8c4fb

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/megatron/bridge/models/conversion/model_bridge.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1490,7 +1490,7 @@ def _share_embeddings_and_output_weights(
14901490
model_config: TransformerConfig,
14911491
) -> bool:
14921492
"""Shared embedding setting."""
1493-
return getattr(model_config, "share_embeddings_and_output_weights")
1493+
return getattr(model_config, "share_embeddings_and_output_weights", False)
14941494

14951495
def _unwrap_name(self, name: str) -> str:
14961496
"""Unwrap name from DDP or other wrappers.

0 commit comments

Comments
 (0)