Skip to content

Support GLM5.2 and recipe for GLM 5.1 & 5.2 on GB200 and H100#4401

Closed
HollowMan6 wants to merge 1 commit into
NVIDIA-NeMo:yuya/unified-perf-recipesfrom
HollowMan6:glm52
Closed

Support GLM5.2 and recipe for GLM 5.1 & 5.2 on GB200 and H100#4401
HollowMan6 wants to merge 1 commit into
NVIDIA-NeMo:yuya/unified-perf-recipesfrom
HollowMan6:glm52

Conversation

@HollowMan6

@HollowMan6 HollowMan6 commented Jun 17, 2026

Copy link
Copy Markdown
Member

Pending NVIDIA/Megatron-LM#5246 to merge and then mcore version bump.

What does this PR do ?

Support GLM5.2 and use correct GLM5.x related flags, as introduced in NVIDIA/Megatron-LM#5246 and related PRs.

Changelog

  • Pass related flags correctly to mcore

GitHub Actions CI

See the CI section in the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

@copy-pr-bot

copy-pr-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@HollowMan6 HollowMan6 changed the title Support GLM5.2 and use GLM5.x related flags Support GLM5.2 and fix GLM5.x related flags Jun 17, 2026
@HollowMan6 HollowMan6 changed the base branch from main to yuya/unified-perf-recipes June 24, 2026 20:58
@HollowMan6 HollowMan6 changed the title Support GLM5.2 and fix GLM5.x related flags Support GLM5.2 and recipe for GLM 5.1 & 5.2 on GB200 and H100 Jun 24, 2026
@HollowMan6 HollowMan6 marked this pull request as ready for review June 24, 2026 21:07
@HollowMan6 HollowMan6 requested a review from yaoyu-33 June 24, 2026 21:07
@yaoyu-33 yaoyu-33 added area:perf Performance optimizations and benchmarking feature New capabilities, enhancements, or enablement work needs-more-tests Requires additional L0 and L1 test coverage before merge needs-review PR is ready for code review and waiting on a reviewer labels Jun 24, 2026
Comment thread src/megatron/bridge/perf_recipes/glm_moe_dsa/gb200/glm5.py Outdated
Comment thread src/megatron/bridge/perf_recipes/glm_moe_dsa/h100/glm5.py Outdated
Signed-off-by: Hollow Man <hollowman@opensuse.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:perf Performance optimizations and benchmarking feature New capabilities, enhancements, or enablement work needs-more-tests Requires additional L0 and L1 test coverage before merge needs-review PR is ready for code review and waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants