Skip to content

test: register internal and gpu pytest markers#4406

Merged
yaoyu-33 merged 1 commit into
r0.5.0from
backport/2026-06-17-internal-pytest-marker-r0.5.0
Jun 19, 2026
Merged

test: register internal and gpu pytest markers#4406
yaoyu-33 merged 1 commit into
r0.5.0from
backport/2026-06-17-internal-pytest-marker-r0.5.0

Conversation

@yaoyu-33

Copy link
Copy Markdown
Contributor

Backports the pytest marker registrations from main commit e9529c3 to unblock strict-marker unit test collection on r0.5.0.

The full main commit also carries unrelated dependency, uv.lock, .main.commit, and Megatron-LM submodule changes, so this PR carries only the pyproject.toml marker hunk.

Validation:

  • python3 -m pre_commit run --all-files: passed
  • uv run pre-commit run --all-files: blocked on macOS ARM because nvidia-resiliency-ext==0.6.0 has no compatible wheel
  • uv run python -m pytest tests/unit_tests/models/qwen_vl/modelling_qwen3_vl/test_attention.py --collect-only -q: blocked by the same dependency resolution issue

Backport the pytest marker registrations from main commit e9529c3 without carrying the unrelated dependency, lockfile, and submodule changes in that commit.

(cherry picked from commit e9529c3)
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@yaoyu-33 yaoyu-33 requested a review from a team as a code owner June 17, 2026 16:20
@copy-pr-bot

copy-pr-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@claude

claude Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

LGTM — clean backport. The two new marker registrations (internal, gpu) are needed because --strict-markers is enabled in addopts and both markers are already in use:

  • tests/functional_tests/test_groups/training/test_distributed_save_hf_weights.py:109@pytest.mark.gpu
  • tests/unit_tests/models/qwen_vl/modelling_qwen3_vl/test_attention.py:129@pytest.mark.internal

Without this registration, pytest --collect-only (and full runs) would fail on r0.5.0 with a PytestUnknownMarkWarning error.

Suggested test cases

No perf tests impacted.

@yaoyu-33 yaoyu-33 merged commit 6b6e07c into r0.5.0 Jun 19, 2026
6 checks passed
@yaoyu-33 yaoyu-33 deleted the backport/2026-06-17-internal-pytest-marker-r0.5.0 branch June 19, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant