fix(kimi-vl): gate dynamic imports on remote code trust#4420
Closed
chtruong814 wants to merge 1 commit into
Closed
fix(kimi-vl): gate dynamic imports on remote code trust#4420chtruong814 wants to merge 1 commit into
chtruong814 wants to merge 1 commit into
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Contributor
|
Review: fix(kimi-vl): gate dynamic imports on remote code trust -- Clean, well-scoped security hardening. The trust flag is propagated correctly through the bridge, provider, and model chain, and the guard in KimiK25VLModel.init fires before any get_class_from_dynamic_module call. Tests cover both the happy path and the rejection path at both layers (bridge and model init). No issues found -- LGTM. -- Suggested test cases: No perf tests impacted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Note: targeted pytest could not be run locally on macOS arm64 because uv cannot install nvidia-resiliency-ext for this platform, and the existing --no-sync environment does not include pytest.