Skip to content

chore(deps): AUT-901 bump Megatron-LM to mcore main b4ad280d#4948

Open
svcnemo-autobot wants to merge 4 commits into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:chore/bump-mcore-main
Open

chore(deps): AUT-901 bump Megatron-LM to mcore main b4ad280d#4948
svcnemo-autobot wants to merge 4 commits into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:chore/bump-mcore-main

Conversation

@svcnemo-autobot

@svcnemo-autobot svcnemo-autobot commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Background

Nightly-style bump of the pinned Megatron-Core commit on main (mirrors the old dependabot.yml (main, main) flow), rebased onto current main.

What changed

Details

  • Submodule/.main.commit: 61f31145b4ad280d.
  • uv.lock: regenerated in the CI container (pytorch 26.06, uv 0.7.2); --upgrade also refreshed ~10 unrelated transitive deps (72 ins / 72 del).
  • tests/unit_tests/doc_consistency/test_readme_consistency.py: _defined_recipe_names() now discovers src/.../recipes/** AND src/.../perf_recipes/**. The training README references qwen3_30b_a3b_pretrain_16gpu_h100_bf16_config (a perf recipe added by feat(training): route performance recipes by name #4945) which the test previously couldn't see — a false 'nonexistent recipes' failure present on main itself.

Tested

  • Container build green; 8132 unit tests passed pre-fix (only the doc test failed).
  • Doc-consistency logic reproduced locally: MISSING=[] after the fix (recipe discovery 513→910).
  • CI on this PR is the gate.

@svcnemo-autobot svcnemo-autobot added dependencies full-test-suite mlm-sync Requires API/behavior sync with upstream Megatron-LM changes needs-more-tests Requires additional L0 and L1 test coverage before merge labels Jul 19, 2026
@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

/ok to test 9d21601

Bump 3rdparty/Megatron-LM to the tip of Megatron-LM main and record it in
.main.commit. uv.lock refresh follows in a separate commit.

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Refresh uv.lock via 'uv lock --upgrade' in the CI container (pytorch 26.06,
uv 0.7.2) after bumping 3rdparty/Megatron-LM to mcore main b4ad280d.

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
test_training_readme_recipes_exist only scanned src/.../recipes/, but
scripts/training/README.md references perf recipes defined under
src/.../perf_recipes/ (e.g. qwen3_30b_a3b_pretrain_16gpu_h100_bf16_config),
causing a false 'nonexistent recipes' failure. Discover both trees.

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

/ok to test 7cef4ad

The file (added upstream by NVIDIA-NeMo#4938) shipped without the NVIDIA Apache-2.0
header, tripping the required copyright-check gate. Add the standard header.

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot svcnemo-autobot added the area:build Dependencies, packaging, images, and environment setup label Jul 19, 2026
@svcnemo-autobot

Copy link
Copy Markdown
Collaborator Author

/ok to test ad2ddec

@yaoyu-33 yaoyu-33 added ci CI, automation, test queue, or workflow infrastructure work needs-review PR is ready for code review and waiting on a reviewer labels Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build Dependencies, packaging, images, and environment setup ci CI, automation, test queue, or workflow infrastructure work dependencies full-test-suite mlm-sync Requires API/behavior sync with upstream Megatron-LM changes needs-more-tests Requires additional L0 and L1 test coverage before merge needs-review PR is ready for code review and waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants