Commit 2f1618d
committed
address Copilot review: memoize YAML loads, add debug logging, fix test name
- Cache resolved YAML files in _resolve_if_path to avoid redundant
disk/network I/O for sibling groups referencing the same file
- Add logging.debug when a path cannot be resolved, so failures
are never fully silent
- Rename misleading test to match its assertion (total depth is 2,
not 1; the unresolvable string is treated as a leaf)
Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>1 parent 2ae9c79 commit 2f1618d
2 files changed
Lines changed: 12 additions & 6 deletions
File tree
- nemo/collections/common/data/lhotse
- tests/collections/common
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
499 | 499 | | |
500 | 500 | | |
501 | 501 | | |
| 502 | + | |
| 503 | + | |
502 | 504 | | |
503 | 505 | | |
504 | 506 | | |
505 | | - | |
506 | | - | |
507 | | - | |
508 | | - | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
509 | 515 | | |
510 | 516 | | |
511 | 517 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
422 | 422 | | |
423 | 423 | | |
424 | 424 | | |
425 | | - | |
426 | | - | |
| 425 | + | |
| 426 | + | |
427 | 427 | | |
428 | 428 | | |
429 | 429 | | |
| |||
0 commit comments