Skip to content

handle issue 15598 for remote code fix#15652

Merged
nithinraok merged 2 commits intomainfrom
fix/rce-trust-remote-code-15598
May 1, 2026
Merged

handle issue 15598 for remote code fix#15652
nithinraok merged 2 commits intomainfrom
fix/rce-trust-remote-code-15598

Conversation

@nithinraok
Copy link
Copy Markdown
Member

What does this PR do ?

Fixes #15598

Collection: ASR

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 29, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@nithinraok nithinraok requested a review from pzelasko April 29, 2026 01:30
@github-actions github-actions Bot added the ASR label Apr 29, 2026
@nithinraok
Copy link
Copy Markdown
Member Author

/claude review

Comment thread nemo/collections/asr/data/huggingface/hf_audio_to_text.py
Comment thread nemo/collections/asr/data/huggingface/hf_audio_to_text.py
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 29, 2026

Review Summary

Missing test coverage: This is a security fix but has no accompanying tests. A unit test that constructs a DictConfig with trust_remote_code=True, passes it through the constructor (or the relevant code path), and asserts the key is stripped before load_dataset is called would be straightforward and valuable — especially since this is a security boundary.

Docstring now inaccurate: Both _HFAudioTextDataset (line 113) and _HFIterableAudioTextDataset (line 388) document hf_data_cfg as "all params in this config will be passed to hf_datasets.load_dataset". That's no longer true — trust_remote_code is now explicitly excluded. Worth updating.

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
@pzelasko
Copy link
Copy Markdown
Collaborator

pzelasko commented May 1, 2026

/ok to test c503d3b

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

[🤖]: Hi @nithinraok 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

@nithinraok nithinraok merged commit 24590f2 into main May 1, 2026
158 of 160 checks passed
@nithinraok nithinraok deleted the fix/rce-trust-remote-code-15598 branch May 1, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential remote code execution via injecting trust_remote_code to hf_data_cfg in model_config.yaml

3 participants