Commit 25dcf41
committed
test(data-plane): move data_plane unit tests under tests/unit/ for CI discovery
tests/unit/L0_Unit_Tests_*.sh hard-code TEST_PATHS=('unit/'), so any test outside tests/unit/ is silently skipped. Our data_plane suite lived at tests/data_plane/unit/ and was never collected by CI.
Move all 19 unit tests + conftest + __init__ into tests/unit/data_plane/ via git mv (one was untracked, so plain mv). The tests/data_plane/functional/ tree stays where it is — those are Tier 2 (Ray + TQ), need a separate runner.
Plus three drive-by fixes flagged by CI lint:
- nemo_rl/data_plane/docs/data_plane_api_lifecycle.md → data-plane-api-lifecycle.md (new pre-commit hook disallows underscores in .md filenames).
- nemo_rl/data_plane/column_io.py:158: change variable annotation Mapping -> dict so pyrefly accepts the dict-comp result at the pack_jagged_fields call site (the function signature is dict[str, ...]). Mapping import drops as unused; ruff auto-fixes.
- nemo_rl/data_plane/worker_mixin.py:224,249: pyrefly no-matching-overload on list(meta.fields) where meta.fields: list[str] | None. Use # type: ignore[no-matching-overload] rather than list(meta.fields or []) — the runtime contract guarantees meta.fields is non-None at these call sites; silently substituting [] would mean fetch-nothing which is wrong.
- nemo_rl/experience/sync_rollout_actor.py: add 'import torch' (F821 — module used torch.zeros_like and isinstance(v, torch.Tensor) without importing torch).
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>1 parent eecbcc4 commit 25dcf41
23 files changed
Lines changed: 161 additions & 4 deletions
File tree
- nemo_rl
- data_plane
- docs
- experience
- tests/unit/data_plane
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
158 | | - | |
| 158 | + | |
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
| |||
File renamed without changes.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
221 | 221 | | |
222 | 222 | | |
223 | 223 | | |
224 | | - | |
| 224 | + | |
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
| |||
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
249 | | - | |
| 249 | + | |
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
0 commit comments