Commit 8c61e94
committed
Fix save_megatron_model deadlock with vLLM inference workers
Pass fully_parallel_save=False to bridge.save_megatron_model() during
HF-to-Megatron conversion. FullyParallelSaveStrategyWrapper calls
all_gather_object on DP sub-groups that include vLLM ranks which never
enter save, causing a permanent deadlock.
Uses inspect.signature for backward compat with Megatron-Bridge versions
that do not yet expose the parameter (see NVIDIA-NeMo/Megatron-Bridge PR).1 parent 0baabd5 commit 8c61e94
1 file changed
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
107 | 108 | | |
108 | 109 | | |
109 | 110 | | |
110 | | - | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
111 | 119 | | |
112 | 120 | | |
113 | 121 | | |
| |||
0 commit comments