Skip to content

Commit b8cbbc4

Browse files
committed
more fixes :(
Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
1 parent 60eeb98 commit b8cbbc4

4 files changed

Lines changed: 11 additions & 13 deletions

File tree

nemo_rl/environments/nemo_gym.py

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -192,30 +192,25 @@ def _postprocess_nemo_gym_to_nemo_rl_result(
192192
if "generation_token_ids" not in output_item_dict:
193193
continue
194194

195-
assert (
196-
seen_token_ids
197-
== output_item_dict["prompt_token_ids"][: len(seen_token_ids)]
198-
), f"""Non-contiguous messages found! This may be a tokenization issue where certain tokens are combined when messages are concatenated, or it may be due to part of the chat history being truncated (like if super long history is truncated or if reasoning is stripped out).
199-
Seen token IDs: {seen_token_ids}
200-
Output prompt token IDs: {output_item_dict["prompt_token_ids"]}
201-
"""
202-
203195
nemo_rl_message_log.append(
204196
{
205197
"role": "user",
206198
"content": "",
207199
"token_ids": torch.tensor(
208-
output_item_dict["prompt_token_ids"][len(seen_token_ids) :]
200+
output_item_dict["prompt_token_ids"][len(seen_token_ids) :],
201+
dtype=torch.long,
209202
),
210203
}
211204
)
212205
nemo_rl_message_log.append(
213206
{
214207
"role": "assistant",
215208
"content": "",
216-
"token_ids": torch.tensor(output_item_dict["generation_token_ids"]),
209+
"token_ids": torch.tensor(
210+
output_item_dict["generation_token_ids"], dtype=torch.long
211+
),
217212
"generation_logprobs": torch.tensor(
218-
output_item_dict["generation_log_probs"]
213+
output_item_dict["generation_log_probs"], dtype=torch.float32
219214
),
220215
}
221216
)

nemo_rl/models/generation/dynamo/dynamo_generation.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,7 @@ def _dynamo_env_vars(self) -> dict[str, str]:
198198
"NATS_SERVER": f"nats://{self._host}:{self._nats_port}",
199199
"DYN_NAMESPACE": self._namespace,
200200
"DYN_DISCOVERY_BACKEND": "etcd",
201+
"DYN_SDK_DISABLE_ANSI_LOGGING": "1",
201202
"DYN_LOG": "dynamo_llm::http::service::metrics=warn,dynamo_runtime::pipeline::network::ingress::push_handler=warn,dynamo_llm::http::service::service_v2=warn,info"
202203
}
203204

@@ -298,7 +299,7 @@ def _start_planner(self) -> None:
298299

299300
planner_config = {
300301
"environment": "virtual",
301-
"mode": "decode",
302+
"mode": "agg",
302303
"backend": "vllm",
303304
"namespace": self._namespace,
304305
"model_name": self.cfg.get("model", "unknown"),

nemo_rl/models/generation/dynamo/dynamo_worker.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,8 @@ def __init__(
276276
kv_events_config_json=kv_events_json,
277277
seed=seed,
278278
),
279+
"--dyn-tool-call-parser", "hermes",
280+
"--dyn-reasoning-parser", "qwen3"
279281
]
280282

281283
# --- Subprocess environment ---

0 commit comments

Comments
 (0)