Skip to content

Commit c336076

Browse files
authored
fix: Fix nanov3 mcore test (#2635)
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
1 parent d9506f7 commit c336076

3 files changed

Lines changed: 25 additions & 102 deletions

File tree

pyproject.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,8 @@ mcore = [
159159
"transformer-engine[pytorch,core_cu13] @ git+https://github.com/NVIDIA/TransformerEngine.git@v2.14.1",
160160
"megatron-core",
161161
"megatron-bridge",
162+
"mamba-ssm",
163+
"causal-conv1d",
162164
"nvidia-modelopt[torch]; sys_platform != 'darwin'",
163165
"onnxscript",
164166
# Flash-attn version should be selected to satisfy both TE + vLLM requirements (xformers in particular)

tests/test_suites/llm/grpo-nanov3-30BA3B-2n8g-megatron-pack-cp.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ uv run tests/json_dump_tb_logs.py $LOG_DIR --output_path $JSON_METRICS
3636
if [[ $(jq 'to_entries | .[] | select(.key == "train/loss") | .value | keys | map(tonumber) | max' $JSON_METRICS) -ge $MAX_STEPS ]]; then
3737
uv run tests/check_metrics.py $JSON_METRICS \
3838
'median(data["train/token_mult_prob_error"]) < 1.1' \
39-
'mean(data["train/gen_kl_error"]) < 0.02' \
40-
'max(data["train/reward"]) > 0.05'
39+
"data['train/token_mult_prob_error']['$MAX_STEPS'] < 1.1" \
40+
'mean(data["train/gen_kl_error"]) < 0.02'
4141

4242
# Clean up checkpoint directory after successful run to save space.
4343
rm -rf "$CKPT_DIR"

0 commit comments

Comments
 (0)