Skip to content

feat: Update Megatron Inference#2355

Merged
terrykong merged 55 commits into
NVIDIA-NeMo:mainfrom
tdene:tde/megatron_inference
Jun 17, 2026
Merged

feat: Update Megatron Inference#2355
terrykong merged 55 commits into
NVIDIA-NeMo:mainfrom
tdene:tde/megatron_inference

Conversation

@tdene

@tdene tdene commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@tdene tdene requested review from a team as code owners April 27, 2026 19:48
@copy-pr-bot

copy-pr-bot Bot commented Apr 27, 2026

Copy link
Copy Markdown

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@tdene tdene changed the title Update Megatron Inference feat: Update Megatron Inference Apr 27, 2026
Comment thread examples/configs/grpo_math_1B_megatron.yaml Outdated
Comment thread examples/configs/grpo_math_1B_megatron.yaml Outdated
Comment thread examples/nemo_gym/grpo_nanov3_megatron.yaml Outdated
Comment thread examples/nemo_gym/grpo_nanov3_megatron.yaml Outdated
Comment thread examples/nemo_gym/grpo_nanov3_megatron.yaml Outdated
Comment thread nemo_rl/models/megatron/setup.py Outdated
Comment thread nemo_rl/models/policy/workers/megatron_policy_worker.py
Comment thread nemo_rl/models/policy/workers/megatron_policy_worker.py Outdated
Comment thread nemo_rl/models/policy/workers/megatron_policy_worker.py
Comment thread nemo_rl/models/policy/workers/megatron_policy_worker.py Outdated
@terrykong

Copy link
Copy Markdown
Collaborator

@joyang-nv @yuki-97 to review

Comment thread examples/nemo_gym/grpo_nanov3_megatron_generation.yaml Outdated
Comment thread nemo_rl/algorithms/grpo.py Outdated
Comment thread nemo_rl/algorithms/grpo.py Outdated
Comment thread nemo_rl/algorithms/grpo.py Outdated
Comment thread nemo_rl/algorithms/grpo.py Outdated
Comment thread nemo_rl/models/policy/workers/megatron_policy_worker.py Outdated
Comment thread nemo_rl/models/policy/workers/megatron_policy_worker.py Outdated
Comment thread nemo_rl/models/policy/workers/megatron_policy_worker.py Outdated
Comment thread nemo_rl/models/policy/workers/megatron_policy_worker.py
Comment thread nemo_rl/models/generation/megatron/megatron_generation.py
@yuki-97

yuki-97 commented May 11, 2026

Copy link
Copy Markdown
Contributor

/claude review

Comment thread nemo_rl/models/megatron/setup.py Outdated
Comment thread nemo_rl/models/policy/workers/megatron_policy_worker.py Outdated
Comment thread nemo_rl/models/policy/workers/megatron_policy_worker.py Outdated
Comment thread nemo_rl/models/policy/workers/megatron_policy_worker.py Outdated
Comment thread nemo_rl/models/policy/workers/megatron_policy_worker.py Outdated
Comment thread nemo_rl/models/generation/megatron/__init__.py Outdated
@tdene tdene force-pushed the tde/megatron_inference branch from 3faae89 to 9d8d522 Compare May 14, 2026 16:27
@tdene tdene requested a review from a team as a code owner May 14, 2026 16:27
@tdene tdene force-pushed the tde/megatron_inference branch 3 times, most recently from 8f00de9 to 67b317c Compare May 18, 2026 19:44
@tdene tdene requested a review from a team as a code owner May 18, 2026 19:44
@tdene tdene force-pushed the tde/megatron_inference branch 2 times, most recently from dd03164 to 262ad18 Compare May 21, 2026 09:55
@tdene tdene requested a review from a team as a code owner May 21, 2026 09:55
@tdene tdene force-pushed the tde/megatron_inference branch 2 times, most recently from a1e550a to 277c4c3 Compare May 22, 2026 15:47
@tdene

tdene commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test e7949e2

@tdene

tdene commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test e7949e2

Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@tdene

tdene commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test d8d1760

tdene added 2 commits June 12, 2026 10:43
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@tdene

tdene commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test a44233b

Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@tdene

tdene commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 27d320f

tdene added 2 commits June 13, 2026 18:06
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@tdene

tdene commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test df4f663

Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@tdene

tdene commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test e1b5f85

Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@tdene

tdene commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 2ba8f0b

tdene added 3 commits June 15, 2026 14:09
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@tdene

tdene commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test dce23c4

Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@tdene

tdene commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test ae64407

tdene added 2 commits June 16, 2026 10:13
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@tdene

tdene commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 2162b37

Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@tdene

tdene commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 71da32a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L1 Run doctests, unit tests, and functional tests CI Relating to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants