Skip to content

feat: Adds a Comet logger#2503

Open
louisfaury wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
louisfaury:lf/add-comet-logger
Open

feat: Adds a Comet logger#2503
louisfaury wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
louisfaury:lf/add-comet-logger

Conversation

@louisfaury
Copy link
Copy Markdown

What does this PR do ?

Adds a CometLogger to use the comet-ml logging backend.

Issues

Afact, there was no open issues for this.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Signed-off-by: Louis Faury <louis.faury@helsing.ai>
@louisfaury louisfaury requested review from a team as code owners May 15, 2026 09:25
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 15, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added Documentation Improvements or additions to documentation community-request labels May 15, 2026
Comment thread nemo_rl/utils/logger.py
print(f"Initialized TensorboardLogger at {log_dir}")

@staticmethod
def _coerce_to_scalar(value: Any) -> int | float | bool | str | None:
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to a function instead of a static method, since this is now also used by the CometLogger.

@louisfaury louisfaury changed the title Adds a Comet logger feat: Adds a Comet logger May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants