fix: update ray executor import for vLLM 0.20#2609
Merged
Conversation
terrykong
approved these changes
May 28, 2026
terrykong
added
the
CI:Lfast
Collaborator
|
/ok to test 679d8f4 |
achartier
force-pushed
the
achartier/fix-fp8-vllm-0.20-ray-executor-import
branch
from
679d8f4 to
c070819
Compare
Contributor
Author
|
/ok to test c070819 |
Contributor
Author
|
Blocked on ci infra, opened fix: #2630 |
vLLM 0.20 renamed the executor module from ray_distributed_executor to ray_executor; the class name RayDistributedExecutor and its collective_rpc method are unchanged. Without this fix, any FP8 generation path that goes through monkey_patch_vllm_ray_executor() with TP*PP > 1 (i.e. any multi-GPU vllm_cfg.precision='fp8' run) fails at worker init with: ModuleNotFoundError: No module named 'vllm.v1.executor.ray_distributed_executor' Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
achartier
force-pushed
the
achartier/fix-fp8-vllm-0.20-ray-executor-import
branch
from
c070819 to
722631b
Compare
Contributor
Author
|
/ok to test 722631b |
Contributor
Author
|
@terrykong I think this is ready to merge |
pengdurice
pushed a commit
to pengdurice/RL
that referenced
this pull request
Jun 12, 2026
Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
fix: update ray executor import for vLLM 0.20
Issues
vLLM 0.20 renamed the executor module from ray_distributed_executor to ray_executor; the class name RayDistributedExecutor and its collective_rpc method are unchanged. Without this fix, any FP8 generation path that goes through monkey_patch_vllm_ray_executor() with TP*PP > 1 (i.e. any multi-GPU vllm_cfg.precision='fp8' run) fails at worker init with:
ModuleNotFoundError: No module named 'vllm.v1.executor.ray_distributed_executor'
Usage
Verified by running GLM-5.1 64n8g with vllm_cfg.precision='fp8' on sl/glm5.1 before the fix (crashes immediately) and after (5/5 training steps complete cleanly).
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information