ci: guard coverage combine against empty coverage glob in fast shards#2630
Merged
chtruong814 merged 1 commit intoMay 29, 2026
Merged
Conversation
PR #2345 split the L1 functional tests into per-domain shards, each ending with an unconditional `coverage combine .coverage*`. Under CI:Lfast (FAST=1), shards with no `run_test fast` tests (AutoModel, Megatron_3) skip every sub-test and produce no .coverage* files. The glob then expands to the literal `.coverage*`, `coverage combine` exits non-zero, and with `set -euo pipefail` the whole shard aborts -> "Did not finish." -> FAILURE. Guard the combine so it is a no-op when there is nothing to combine, while still surfacing real combine failures when coverage files exist. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
Contributor
Author
|
/ok to test a45a19b |
4 tasks
chtruong814
approved these changes
May 29, 2026
Contributor
|
@achartier thanks for this! I was working on the fix as well and saw your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Guard the trailing
coverage combine .coverage*in all 13L1_Functional_Tests_*.shshard scripts so it is skipped when no coverage files were produced.Why
#2345 split the monolithic L1 functional tests into per-domain shards, each ending with an unconditional
coverage combine .coverage*. UnderCI:Lfast(FAST=1),run_testskips every sub-test not markedfast. The AutoModel and Megatron_3 shards have zerorun_test fasttests, so nothing runs and no.coverage*files are produced. The glob then expands to the literal.coverage*,coverage combineexits non-zero ("Couldn't combine from non-existent path"), and withset -euo pipefailthe whole shard aborts → the harness reports "Did not finish." → FAILURE.This makes
fast_L1_Functional_Tests_AutoModelandfast_L1_Functional_Tests_Megatron_3red on everyCI:LfastPR since #2345 merged. The other shards survive only because they each happen to have ≥1 fast test producing a coverage file.Fix scope
The broken-today shards are AutoModel and Megatron_3, but the identical unguarded tail exists in all 13 shards, so the guard is applied uniformly to prevent the same latent failure if the last fast test is ever removed from another shard.
The guard still surfaces genuine
coverage combinefailures when coverage files do exist — it only no-ops the empty case.Labeled
CI:Lfastso the previously-failing AutoModel/Megatron_3 fast shards exercise this fix directly.cc @chtruong814 (author of #2345)