Skip to content

ci: guard coverage combine against empty coverage glob in fast shards #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chtruong814 merged 1 commit into from
May 29, 2026
Merged

ci: guard coverage combine against empty coverage glob in fast shards #2630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/functional/L1_Functional_Tests_AutoModel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,6 @@ run_test uv run --no-sync bash ./tests/functional/sft_automodel_lora.sh
run_test uv run --no-sync bash ./tests/functional/test_automodel_extra_installed_correctly.sh

cd ${PROJECT_ROOT}/tests
coverage combine .coverage*
if compgen -G ".coverage*" > /dev/null; then
coverage combine .coverage*
fi
4 changes: 3 additions & 1 deletion tests/functional/L1_Functional_Tests_Eval.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,6 @@ run_test uv run --no-sync bash ./tests/functional/eval_async.sh
run_test fast uv run --no-sync bash ./tests/functional/eval_audio.sh

cd ${PROJECT_ROOT}/tests
coverage combine .coverage*
if compgen -G ".coverage*" > /dev/null; then
coverage combine .coverage*
fi
4 changes: 3 additions & 1 deletion tests/functional/L1_Functional_Tests_GRPO_1.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,6 @@ run_test fast uv run --no-sync bash ./tests/functional/grpo_dp_simple.sh
run_test fast uv run --no-sync bash ./tests/functional/grpo_dp_mooncake.sh

cd ${PROJECT_ROOT}/tests
coverage combine .coverage*
if compgen -G ".coverage*" > /dev/null; then
coverage combine .coverage*
fi
4 changes: 3 additions & 1 deletion tests/functional/L1_Functional_Tests_GRPO_2.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,6 @@ run_test uv run --no-sync bash ./tests/functional/grpo_multiturn.sh
run_test uv run --no-sync bash ./tests/functional/grpo_non_colocated.sh

cd ${PROJECT_ROOT}/tests
coverage combine .coverage*
if compgen -G ".coverage*" > /dev/null; then
coverage combine .coverage*
fi
4 changes: 3 additions & 1 deletion tests/functional/L1_Functional_Tests_GRPO_3.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,6 @@ run_test fast uv run --no-sync bash ./tests/functional/grpo_topp_topk.sh
run_test uv run --no-sync bash ./tests/functional/vlm_grpo.sh

cd ${PROJECT_ROOT}/tests
coverage combine .coverage*
if compgen -G ".coverage*" > /dev/null; then
coverage combine .coverage*
fi
4 changes: 3 additions & 1 deletion tests/functional/L1_Functional_Tests_Gym.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,6 @@ run_test() {
run_test fast uv run --no-sync bash ./tests/functional/grpo_async_gym.sh

cd ${PROJECT_ROOT}/tests
coverage combine .coverage*
if compgen -G ".coverage*" > /dev/null; then
coverage combine .coverage*
fi
4 changes: 3 additions & 1 deletion tests/functional/L1_Functional_Tests_Megatron_1.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,6 @@ run_test fast uv run --no-sync bash ./tests/functional/grpo_megatron_eagle3_onli
run_test uv run --no-sync bash ./tests/functional/grpo_megatron_generation.sh

cd ${PROJECT_ROOT}/tests
coverage combine .coverage*
if compgen -G ".coverage*" > /dev/null; then
coverage combine .coverage*
fi
4 changes: 3 additions & 1 deletion tests/functional/L1_Functional_Tests_Megatron_2.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,6 @@ run_test fast uv run --no-sync bash ./tests/functional/dpo_megatron_lora.sh
run_test uv run --no-sync bash ./tests/functional/sft_megatron_lora.sh

cd ${PROJECT_ROOT}/tests
coverage combine .coverage*
if compgen -G ".coverage*" > /dev/null; then
coverage combine .coverage*
fi
4 changes: 3 additions & 1 deletion tests/functional/L1_Functional_Tests_Megatron_3.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,6 @@ run_test uv run --no-sync bash ./tests/functional/dpo_megatron.sh
run_test uv run --no-sync bash ./tests/functional/sft_megatron.sh

cd ${PROJECT_ROOT}/tests
coverage combine .coverage*
if compgen -G ".coverage*" > /dev/null; then
coverage combine .coverage*
fi
4 changes: 3 additions & 1 deletion tests/functional/L1_Functional_Tests_Other_1.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,6 @@ if [[ "${FAST:-0}" != "1" ]]; then
fi

cd ${PROJECT_ROOT}/tests
coverage combine .coverage*
if compgen -G ".coverage*" > /dev/null; then
coverage combine .coverage*
fi
4 changes: 3 additions & 1 deletion tests/functional/L1_Functional_Tests_Other_2.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,6 @@ run_test uv run --no-sync bash ./tests/functional/prorlv2.sh
run_test uv run --no-sync bash ./tests/functional/rm.sh

cd ${PROJECT_ROOT}/tests
coverage combine .coverage*
if compgen -G ".coverage*" > /dev/null; then
coverage combine .coverage*
fi
4 changes: 3 additions & 1 deletion tests/functional/L1_Functional_Tests_SFT.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,6 @@ run_test uv run --no-sync bash ./tests/functional/sft_avlm.sh
run_test uv run --no-sync bash ./tests/functional/sft_resume_diamond.sh

cd ${PROJECT_ROOT}/tests
coverage combine .coverage*
if compgen -G ".coverage*" > /dev/null; then
coverage combine .coverage*
fi
4 changes: 3 additions & 1 deletion tests/functional/L1_Functional_Tests_SGLang.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,6 @@ run_test() {
run_test uv run --no-sync bash ./tests/functional/grpo_sglang.sh

cd ${PROJECT_ROOT}/tests
coverage combine .coverage*
if compgen -G ".coverage*" > /dev/null; then
coverage combine .coverage*
fi
Loading