Add RayJob and Slurm support for Ray APIs + integration with run.Experiment#236
Merged
Conversation
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
…ple times Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Hemil Desai <hemil.desai10@gmail.com> Signed-off-by: Hemil Desai <hemild@nvidia.com>
… autoescape=False Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Hemil Desai <hemil.desai10@gmail.com> Signed-off-by: Hemil Desai <hemild@nvidia.com>
… with implicit (fall through) returns Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Hemil Desai <hemil.desai10@gmail.com> Signed-off-by: Hemil Desai <hemild@nvidia.com>
4d99bf3 to
3906fa2
Compare
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Comment on lines
+821
to
+828
| def start( | ||
| self, | ||
| command: str, | ||
| workdir: str | None = None, | ||
| runtime_env_yaml: str | None = None, | ||
| pre_ray_start_commands: Optional[list[str]] = None, | ||
| dryrun: bool = False, | ||
| ): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the issue, we will add an explicit return None at the end of the start function. This ensures that the function's return behavior is clear and consistent, even if it is not intended to return a meaningful value. The change will be made at the end of the start function, after all existing logic.
Suggested changeset
1
nemo_run/run/ray/kuberay.py
| @@ -894,2 +894,3 @@ | ||
| # *job* helpers, keeping cluster classes focused on cluster lifecycle | ||
| return None | ||
| # only. |
Copilot is powered by AI and may make mistakes. Always verify output.
terrykong
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage with RayCluster API:
Usage with run.Experiment