-
Notifications
You must be signed in to change notification settings - Fork 103
Add RayCluster support for DGX Cloud Lepton #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
433d0d0
Add Ray support for DGX Cloud Lepton
roclark 38269ef
making name unique and add resource shape for lepton raycluster
zoeyz101 5f23d75
adding head node reference in RayCluster, support defining secrets in…
zoeyz101 baf4c05
Remove Slurm packager comments from RayCluster
roclark cabaea0
Fix RayCluster head resource shape
roclark 96d3ac5
Update LeptonRay comments
roclark 89106cf
Fix RayJob logs streaming connection dropping
roclark 5932818
Make RayCluster head resource shape optional
roclark 8fbfacc
Add doc for DGXC Lepton RayClusters
roclark 6814188
Update license date
roclark 8465573
Fix Ray guide typo
roclark b8d96a8
Make cluster readiness timeout a variable
roclark 9cef6d1
Remove implicit returns
roclark 4d138d6
Remove unused local variable
roclark 92cb237
Fix linting errors
roclark 6436277
Fix formatting errors
roclark a5c8fea
Move LeptonExecutor parameters to definition
roclark 9c02ff5
Updated leptonai package version
roclark 5cec02e
Add Lepton RayCluster tests
roclark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
three instead of two helper and I would say three helper executors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I interpreted the helpers being the
RayClusterandRayJobobjects with the different executors being the backends.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I interpreted this as the helpers being the executors. @hemildesai can you confirm? RayJob and RayCluster do not have the same API