fix: Catch can't start new thread#453
Merged
Merged
Conversation
Signed-off-by: oliver könig <okoenig@nvidia.com>
malay-nagda
previously approved these changes
Mar 11, 2026
chtruong814
reviewed
Mar 11, 2026
| ) | ||
| time.sleep(thread_retry_delay) | ||
| thread_retry_delay = min(thread_retry_delay * 2, 60) | ||
| continue |
Contributor
There was a problem hiding this comment.
What are consequences with constantly hitting can't start new thread error? The number of tries is not incremented here. But is there a point where something is really wrong and we should just fail?
Contributor
Author
There was a problem hiding this comment.
hmm.. yeah, let's change that to exponential backoff with maybe 5 retries
Signed-off-by: oliver könig <okoenig@nvidia.com>
chtruong814
approved these changes
Mar 11, 2026
svcnvidia-nemo-ci
pushed a commit
that referenced
this pull request
Mar 11, 2026
* fix: Catch `can't start new thread` Signed-off-by: oliver könig <okoenig@nvidia.com> * add exponential backoff Signed-off-by: oliver könig <okoenig@nvidia.com> --------- Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
ko3n1g
added a commit
that referenced
this pull request
Mar 11, 2026
* fix: Catch `can't start new thread` * add exponential backoff --------- Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.