Skip to content

Commit 0ad7b49

Browse files
committed
Address review feedback on GRPO sandbox integration
Signed-off-by: Wei Du <wedu@nvidia.com>
1 parent 1e4f5a7 commit 0ad7b49

4 files changed

Lines changed: 17 additions & 552 deletions

File tree

dockerfiles/README.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,17 @@ We directly use official `nvcr.io/nvidia/tensorrt-llm/release:1.3.0rc8` image.
3232

3333
## Building sglang image
3434

35+
<<<<<<< HEAD
3536
We directly use official `lmsysorg/sglang:v0.5.10.post1` image.
37+
=======
38+
We directly use official `lmsysorg/sglang:v0.5.8` image.
39+
40+
## NeMo-RL image default
41+
42+
The sample local cluster config currently defaults `containers.nemo-rl` to the pinned private image
43+
`nvcr.io/nvidian/nemo-rl:733c7d6-48669320`. This image is accessible to NVIDIA employees who already have access
44+
to the corresponding internal registry.
45+
46+
If you do not have access to that registry, build the NeMo-RL image yourself from the matching commit in the
47+
upstream NeMo-RL repository and point your cluster config at that locally built image instead.
48+
>>>>>>> 1a725b3d (Address review feedback on GRPO sandbox integration)

nemo_skills/pipeline/nemo_rl/grpo.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,9 @@ def grpo_nemo_rl(
333333
help="If specified, will reuse the code from this experiment. "
334334
"Can provide an experiment name or an experiment object if running from code.",
335335
),
336-
config: str = typer.Option(None, help="Override training config YAML; defaults to the upstream container config"),
336+
config: str = typer.Option(
337+
None, help="Override training config YAML; defaults to the upstream container config for nano-v3"
338+
),
337339
container: str = typer.Option(None, help="Override container image for NeMo-RL training/conversion jobs"),
338340
with_sandbox: bool = typer.Option(False, help="If True, will start a sandbox container alongside this job"),
339341
sandbox_container: str = typer.Option(None, help="Override container image for the sandbox sidecar"),

0 commit comments

Comments
 (0)