fix(deployments): filter reconciler lists on data.status (AIRCORE-756)

Entity store persists deployment and volume status under the data JSON
column; filtering on top-level status caused list queries to fail and left
DELETING deployments stuck. Align controller and status_in list API with
data.status and update unit test expectations.

Signed-off-by: Tyler Bray <tbray@nvidia.com>

Author: tylersbray

plugins/nemo-deployments/src/nemo_deployments_plugin/api/v2/deployments.py

@@ -126,7 +126,7 @@ async def list_deployments(
     if statuses:
         filter_operation = ComparisonOperation(
             operator=FilterOperator.IN,
-            field="status",
+            field="data.status",
             value=statuses,
         )
     result = await entity_client.list(

plugins/nemo-deployments/src/nemo_deployments_plugin/controller.py

@@ -179,7 +179,7 @@ async def _list_deployments(self) -> list[Deployment]:
                 Deployment,
                 filter_operation=ComparisonOperation(
                     operator=FilterOperator.IN,
-                    field="status",
+                    field="data.status",
                     value=list(NON_TERMINAL_DEPLOYMENT_STATUSES),
                 ),
             )
@@ -197,7 +197,7 @@ async def _list_volumes(self) -> list[Volume]:
                 Volume,
                 filter_operation=ComparisonOperation(
                     operator=FilterOperator.IN,
-                    field="status",
+                    field="data.status",
                     value=list(NON_TERMINAL_VOLUME_STATUSES),
                 ),
             )
@@ -218,7 +218,7 @@ async def _list_terminal_deployments_for_orphan_grace(self) -> list[Deployment]:
                 Deployment,
                 filter_operation=ComparisonOperation(
                     operator=FilterOperator.IN,
-                    field="status",
+                    field="data.status",
                     value=list(_TERMINAL_ORPHAN_STATUSES),
                 ),
             )

plugins/nemo-deployments/tests/unit/reconciler/test_entity_client.py

@@ -37,7 +37,7 @@ async def test_list_all_pages_fetches_multiple_pages() -> None:
         Deployment,
         filter_operation=ComparisonOperation(
             operator=FilterOperator.IN,
-            field="status",
+            field="data.status",
             value=["PENDING"],
         ),
     )

plugins/nemo-deployments/tests/unit/test_api_deployments.py

@@ -104,7 +104,7 @@ def test_list_deployments_status_in(client: TestClient, mock_entity_client: Asyn
     assert len(resp.json()["data"]) == 1
     call_kwargs = mock_entity_client.list.await_args.kwargs
     assert call_kwargs["filter_operation"].operator.value == "$in"
-    assert call_kwargs["filter_operation"].field == "status"
+    assert call_kwargs["filter_operation"].field == "data.status"
 
 
 def test_list_deployments_invalid_status_in_400(client: TestClient) -> None: