fix pr comments

Signed-off-by: Sean Teramae <steramae@nvidia.com>

Author: steramae-nvidia

web/packages/studio/src/routes/DataDesignerJobDetailsRoute/DataDesignerConfigPanel.tsx

@@ -11,7 +11,7 @@ import {
   type BuilderConfigSummary,
 } from '@studio/routes/DataDesignerJobDetailsRoute/builderConfig';
 import { useDataDesignerArtifactsFileset } from '@studio/routes/DataDesignerJobDetailsRoute/useDataDesignerArtifactsFileset';
-import { FC, useMemo } from 'react';
+import { useMemo, type FC } from 'react';
 
 export interface DataDesignerConfigPanelProps {
   open: boolean;
@@ -56,9 +56,9 @@ const ConfigSummary: FC<{ summary: BuilderConfigSummary }> = ({ summary }) => (
         <Divider />
         <Stack gap="density-md">
           <Text kind="label/semibold/md">Models</Text>
-          {summary.models.map((model) => (
+          {summary.models.map((model, index) => (
             <KVPair
-              key={model.alias}
+              key={`${model.alias}-${index}`}
               label={model.alias}
               value={model.provider ? `${model.model} (${model.provider})` : model.model}
             />
@@ -72,9 +72,9 @@ const ConfigSummary: FC<{ summary: BuilderConfigSummary }> = ({ summary }) => (
         <Divider />
         <Stack gap="density-md">
           <Text kind="label/semibold/md">Columns</Text>
-          {summary.columns.map((column) => (
+          {summary.columns.map((column, index) => (
             <KVPair
-              key={column.name}
+              key={`${column.name}-${index}`}
               label={column.name}
               value={column.modelAlias ? `${column.type} · ${column.modelAlias}` : column.type}
             />

web/packages/studio/src/routes/DataDesignerJobDetailsRoute/DatasetProfilerSection.tsx

@@ -18,7 +18,7 @@ import {
 } from '@studio/routes/DataDesignerJobDetailsRoute/datasetProfilerTypes';
 import { useDataDesignerJobAnalysis } from '@studio/routes/DataDesignerJobDetailsRoute/useDataDesignerJobAnalysis';
 import { useDataDesignerJobFromRoute } from '@studio/routes/DataDesignerJobDetailsRoute/useDataDesignerJobFromRoute';
-import { FC } from 'react';
+import type { FC } from 'react';
 
 const ColumnGrid: FC<{ children: React.ReactNode }> = ({ children }) => (
   <Grid cols={{ xs: 1, sm: 2, xl: 3 }} gap="density-lg">
@@ -54,7 +54,7 @@ export const DatasetProfilerSection: FC = () => {
     );
   }
 
-  if (isLoading && !hasAnalysis) {
+  if (isLoading && !analysis) {
     return (
       <ColumnGrid>
         {Array.from({ length: 6 }, (_, i) => (

web/packages/studio/src/routes/DataDesignerJobDetailsRoute/JobOutputFilesetSection.tsx

@@ -17,7 +17,7 @@ import { useDataDesignerArtifactsFileset } from '@studio/routes/DataDesignerJobD
 import { getFilesetDetailsRoute } from '@studio/routes/utils';
 import { getHumanReadableFileSize } from '@studio/util/files';
 import { useQueryClient } from '@tanstack/react-query';
-import { ComponentProps, FC, useCallback, useEffect, useMemo, useState } from 'react';
+import { useCallback, useEffect, useMemo, useState, type ComponentProps, type FC } from 'react';
 import { Link, useNavigate } from 'react-router-dom';
 
 type FileRow = FilesetFileOutput & { id: string };
@@ -45,6 +45,8 @@ export const JobOutputFilesetSection: FC = () => {
     listFilesParams,
     files,
     isResultsLoading,
+    isResultsError,
+    resultsError,
     isFilesLoading,
     isFilesError: isListFilesError,
     filesError: listFilesError,
@@ -150,6 +152,20 @@ export const JobOutputFilesetSection: FC = () => {
     );
   }
 
+  if (isResultsError) {
+    return (
+      <Card>
+        <Stack gap="4">
+          <Banner kind="inline" status="error" title="Could not load job results">
+            {resultsError instanceof Error
+              ? resultsError.message
+              : 'The job results list could not be loaded.'}
+          </Banner>
+        </Stack>
+      </Card>
+    );
+  }
+
   if (!artifactsResult) {
     return (
       <Card>

web/packages/studio/src/routes/DataDesignerJobDetailsRoute/builderConfig.ts

@@ -15,32 +15,32 @@
 export const BUILDER_CONFIG_FILENAME = 'builder_config.json';
 
 export interface BuilderConfigColumnSummary {
-  name: string;
-  type: string;
-  modelAlias?: string;
+  readonly name: string;
+  readonly type: string;
+  readonly modelAlias?: string;
 }
 
 export interface BuilderConfigModelSummary {
-  alias: string;
-  model: string;
-  provider?: string;
+  readonly alias: string;
+  readonly model: string;
+  readonly provider?: string;
 }
 
 export interface BuilderConfigSeedSummary {
-  type: string;
-  samplingStrategy?: string;
+  readonly type: string;
+  readonly samplingStrategy?: string;
 }
 
 export interface BuilderConfigSummary {
-  columnCount: number;
-  columns: BuilderConfigColumnSummary[];
-  columnTypeBreakdown: Array<{ type: string; count: number }>;
-  models: BuilderConfigModelSummary[];
-  seed?: BuilderConfigSeedSummary;
-  constraintCount: number;
-  profilerCount: number;
-  processorNames: string[];
-  libraryVersion?: string;
+  readonly columnCount: number;
+  readonly columns: BuilderConfigColumnSummary[];
+  readonly columnTypeBreakdown: Array<{ type: string; count: number }>;
+  readonly models: BuilderConfigModelSummary[];
+  readonly seed?: BuilderConfigSeedSummary;
+  readonly constraintCount: number;
+  readonly profilerCount: number;
+  readonly processorNames: string[];
+  readonly libraryVersion?: string;
 }
 
 const asRecord = (value: unknown): Record<string, unknown> | undefined =>

web/packages/studio/src/routes/DataDesignerJobDetailsRoute/datasetProfilerTypes.ts

@@ -133,7 +133,13 @@ export interface DatasetProfilerResults {
 
 const LLM_COLUMN_TYPES = new Set(['llm-text', 'llm-code', 'llm-structured', 'llm-judge']);
 
-export const isLLMColumnStatistics = (stats: ColumnStatistics): stats is LLMTextColumnStatistics =>
+export type LLMColumnStatistics =
+  | LLMTextColumnStatistics
+  | LLMCodeColumnStatistics
+  | LLMStructuredColumnStatistics
+  | LLMJudgedColumnStatistics;
+
+export const isLLMColumnStatistics = (stats: ColumnStatistics): stats is LLMColumnStatistics =>
   LLM_COLUMN_TYPES.has(stats.column_type);
 
 export const isValidationColumnStatistics = (
@@ -149,7 +155,8 @@ export const getPercentComplete = (results: DatasetProfilerResults): number => {
   if (results.target_num_records <= 0) {
     return 0;
   }
-  return (100 * results.num_records) / results.target_num_records;
+  const percent = (100 * results.num_records) / results.target_num_records;
+  return Math.max(0, Math.min(100, percent));
 };
 
 /** `num_unique / num_records` as a percentage, or undefined when unavailable. */

web/packages/studio/src/routes/DataDesignerJobDetailsRoute/index.tsx

@@ -22,7 +22,7 @@ import { JobOutputFilesetSection } from '@studio/routes/DataDesignerJobDetailsRo
 import { useDataDesignerJobFromRoute } from '@studio/routes/DataDesignerJobDetailsRoute/useDataDesignerJobFromRoute';
 import { getDataDesignerJobListRoute } from '@studio/routes/utils';
 import { ArrowLeft, FileJson } from 'lucide-react';
-import { FC, useState } from 'react';
+import { useState, type FC } from 'react';
 import { Link } from 'react-router-dom';
 
 export const DataDesignerJobDetailsRoute: FC = () => {

web/packages/studio/src/routes/DataDesignerJobDetailsRoute/useDataDesignerArtifactsFileset.ts

@@ -23,10 +23,14 @@ export const useDataDesignerArtifactsFileset = () => {
 
   const isTerminal = job?.status != null && PlatformJobTerminalStatuses.includes(job.status);
 
-  const { data: resultsResponse, isLoading: isResultsLoading } =
-    useDataDesignerListCreateJobResults(workspace, jobName, {
-      query: { refetchInterval: isTerminal ? false : 3000 },
-    });
+  const {
+    data: resultsResponse,
+    isLoading: isResultsLoading,
+    isError: isResultsError,
+    error: resultsError,
+  } = useDataDesignerListCreateJobResults(workspace, jobName, {
+    query: { refetchInterval: isTerminal ? false : 3000 },
+  });
 
   const artifactsResult = useMemo(() => {
     const data = resultsResponse?.data;
@@ -83,6 +87,8 @@ export const useDataDesignerArtifactsFileset = () => {
     listFilesParams,
     files,
     isResultsLoading,
+    isResultsError,
+    resultsError,
     isFilesLoading,
     isFilesError,
     filesError,

web/packages/studio/src/routes/DataDesignerJobDetailsRoute/useDataDesignerJobAnalysis.ts

@@ -30,10 +30,14 @@ export const useDataDesignerJobAnalysis = (
   jobName: string,
   { enabled = true }: UseDataDesignerJobAnalysisOptions = {}
 ) => {
-  const { data: resultsResponse, isLoading: isResultsLoading } =
-    useDataDesignerListCreateJobResults(workspace, jobName, {
-      query: { enabled: enabled && Boolean(workspace && jobName) },
-    });
+  const {
+    data: resultsResponse,
+    isLoading: isResultsLoading,
+    isError: isResultsError,
+    error: resultsError,
+  } = useDataDesignerListCreateJobResults(workspace, jobName, {
+    query: { enabled: enabled && Boolean(workspace && jobName) },
+  });
 
   const hasAnalysis = Boolean(
     resultsResponse?.data?.some((result) => result.name === ANALYSIS_RESULT_NAME)
@@ -62,7 +66,7 @@ export const useDataDesignerJobAnalysis = (
     analysis: analysisQuery.data,
     hasAnalysis,
     isLoading: isResultsLoading || (hasAnalysis && analysisQuery.isLoading),
-    isError: analysisQuery.isError,
-    error: analysisQuery.error,
+    isError: isResultsError || analysisQuery.isError,
+    error: resultsError ?? analysisQuery.error,
   };
 };