Skip to content

Commit dcaf12f

Browse files
committed
Address CodeRabbit
Signed-off-by: Jash Gulabrai <jgulabrai@nvidia.com>
1 parent 8a55a3a commit dcaf12f

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1095,11 +1095,13 @@ jobs:
10951095
uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
10961096
with:
10971097
path: nemo-platform
1098+
persist-credentials: false
10981099
- name: Checkout NeMo-Guardrails
10991100
uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
11001101
with:
11011102
repository: NVIDIA/NeMo-Guardrails
11021103
path: NeMo-Guardrails
1104+
persist-credentials: false
11031105
- name: Install uv
11041106
uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
11051107
with:
@@ -1152,6 +1154,7 @@ jobs:
11521154
uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
11531155
with:
11541156
path: nemo-platform
1157+
persist-credentials: false
11551158
- name: Download with-guardrails artifact
11561159
# If a variant failed entirely it may have uploaded no artifact;
11571160
# the analyzer handles the single-variant case so don't fail here.

plugins/nemo-guardrails/benchmarks/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -224,9 +224,9 @@ across the two variants.
224224
(in ms) per concurrency level. Edit by hand when a real change shifts
225225
the numbers.
226226

227-
Worked example: at c=16 the override is 300 ms, so a run with observed
228-
delta_p50 = 1689 (diff +299 from baseline 1390) passes; observed
229-
delta_p50 = 1691 (diff +301) fails.
227+
Worked example: at c=16 the override is 200 ms, so a run with observed
228+
delta_p50 = 1689 (diff +199 from baseline 1390) passes; observed
229+
delta_p50 = 1691 (diff +201) fails.
230230

231231
Notes on the current values:
232232

0 commit comments

Comments
 (0)