refactor(studio): consolidate four delete modals into generic BulkDeleteModal#439
refactor(studio): consolidate four delete modals into generic BulkDeleteModal#439aray12 wants to merge 17 commits into
DCO
There are 10 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.
To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
Here is how to fix the problem so that this code can be merged.
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using
--allow-empty)
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~17 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin astd-232-merge-near-identical-delete-modals-into-one-generic
Summary
Commit sha: 291cff5, Author: Alex Ray, Committer: GitHub; Can not find "Alex Ray aray12@users.noreply.github.com", in ["Alex Ray alray@nvidia.com", "Alex Ray alray@nvidia.com", "Alex Ray alray@nvidia.com"].
Commit sha: d62ec76, Author: Brooke Storm, Committer: GitHub; Can not find "Brooke Storm crookedstorm@users.noreply.github.com", in ["Brooke Storm brookes@nvidia.com", "Brooke Storm brookes@nvidia.com", "Brooke Storm brookes@nvidia.com", "Brooke Storm brookes@nvidia.com", "Brooke Storm brookes@nvidia.com"].
Commit sha: bb55403, Author: htolentino-nvidia, Committer: GitHub; Expected "htolentino-nvidia htolentino@nvidia.com", but got "Henrique Tolentino htolentino@nvidia.com".
Commit sha: 7969805, Author: htolentino-nvidia, Committer: GitHub; Can not find "htolentino-nvidia htolentino@nvidia.com", in ["Henrique Tolentino htolentino@nvidia.com", "Henrique Tolentino htolentino@nvidia.com", "Henrique Tolentino htolentino@nvidia.com", "Henrique Tolentino htolentino@nvidia.com", "Henrique Tolentino htolentino@nvidia.com"].
Commit sha: 95b728e, Author: Nathan Walston, Committer: GitHub; Can not find "Nathan Walston walston@users.noreply.github.com", in ["Nathan Walston nwalston@nvidia.com", "Nathan Walston nwalston@nvidia.com", "Nathan Walston nwalston@nvidia.com", "Nathan Walston nwalston@nvidia.com"].
Commit sha: a0a3641, Author: Nikko, Committer: GitHub; Can not find "Nikko nakolean@gmail.com", in ["Nicholas Kolean nakolean@gmail.com", "Nicholas Kolean nakolean@gmail.com", "Nicholas Kolean nakolean@gmail.com", "Nicholas Kolean nakolean@gmail.com"].
Commit sha: d8ea9e2, Author: nv-odrulea, Committer: GitHub; Can not find "nv-odrulea odrulea@nvidia.com", in ["Octavian Drulea odrulea@nvidia.com", "Octavian Drulea odrulea@nvidia.com", "Octavian Drulea odrulea@nvidia.com", "Octavian Drulea odrulea@nvidia.com", "Octavian Drulea odrulea@nvidia.com"].
Commit sha: 04bd2a5, Author: Ryan Sadler, Committer: GitHub; Expected "Ryan Sadler 267728323+ironcommit@users.noreply.github.com", but got "Ryan S 267728323+ironcommit@users.noreply.github.com".
Commit sha: 4a3a16e, Author: Ryan Sadler, Committer: GitHub; Expected "Ryan Sadler 267728323+ironcommit@users.noreply.github.com", but got "Ryan S 267728323+ironcommit@users.noreply.github.com".
Commit sha: afb3001, Author: Swarom, Committer: GitHub; Expected "Swarom smuley@nvidia.com", but got "Swarom Muley smuley@nvidia.com".