fix(studio): Fileset panel animations#441
Open
steramae-nvidia wants to merge 2 commits into
Open
Conversation
Signed-off-by: Sean Teramae <steramae@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughFileset preview close handling now queues breadcrumb navigation through the panel close lifecycle, adds an onClosing callback, updates route panel state from URL params, and changes the tests to wait for deferred callbacks. ChangesFileset preview panel closing
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/studio/src/components/FilesetFilePreviewPanel/index.test.tsx`:
- Around line 225-230: The breadcrumb and folder-click tests in the
FilesetFilePreviewPanel suite only verify eventual callback execution, so they
can miss regressions where navigation happens synchronously. Update the affected
tests around onFolderClick and the folder breadcrumb clicks to assert
immediately after each fireEvent.click that the callback has not yet been
called, then keep the existing awaited expectation to confirm it fires later.
Apply this pattern in the relevant test cases that currently rely on waitFor
alone.
In `@web/packages/studio/src/routes/FilesetListRoute/PanelManagement/index.tsx`:
- Around line 47-49: The dataset side panel is being unmounted too early because
showDatasetPanel is tied directly to datasetIdFromUrl, and the close handler in
PanelManagement removes that URL before the exit animation can run. Update the
panel state flow so DatasetFileManagementSidePanel stays mounted with
open={false} while closing, using a separate closing dataset id or deferring the
URL cleanup until close-complete. Make sure the logic around showDatasetPanel,
the close handler, and the DatasetFileManagementSidePanel open/close wiring all
work together to preserve the panel during animation.
- Around line 43-44: Stop decoding the route params in PanelManagement:
useParams() already provides decoded values and getFilesetFileRoute() handles
encoding, so the extra decodeURIComponent calls on datasetIdFromUrl and
filePathFromUrl can throw on valid names containing %. Remove the redundant
decoding in the PanelManagement component and use the params directly where
datasetIdFromUrl and filePathFromUrl are assigned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6c4a7571-da21-44ce-929f-8fbad0037304
📒 Files selected for processing (4)
web/packages/studio/src/components/FilesetFilePreviewPanel/index.test.tsxweb/packages/studio/src/components/FilesetFilePreviewPanel/index.tsxweb/packages/studio/src/components/filesets/FilesetSidePanelWrapper/index.tsxweb/packages/studio/src/routes/FilesetListRoute/PanelManagement/index.tsx
Contributor
|
Signed-off-by: Sean Teramae <steramae@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-06-24.at.12.04.59.PM.mov
Summary by CodeRabbit