Skip to content

fix(retargeting): DLPack copy order and optional transform tests#386

Merged
nvddr merged 1 commit intorelease/1.1.xfrom
devdeepr/cherryPickNumpy
Apr 13, 2026
Merged

fix(retargeting): DLPack copy order and optional transform tests#386
nvddr merged 1 commit intorelease/1.1.xfrom
devdeepr/cherryPickNumpy

Conversation

@nvddr
Copy link
Copy Markdown
Contributor

@nvddr nvddr commented Apr 10, 2026

  • Copy ndarray slots via np.from_dlpack(input).copy() before in-place transforms
  • Numpy version tests / smoke; requirements numpy>=1.23
  • Tests for optional absent/present toggling across calls

- Copy ndarray slots via np.from_dlpack(input).copy() before in-place transforms
- Numpy version tests / smoke; requirements numpy>=1.23
- Tests for optional absent/present toggling across calls
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 10, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: f4d95009-4ada-4982-9893-c163d102820e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devdeepr/cherryPickNumpy

Comment @coderabbitai help to get the list of available commands and usage tips.

@nvddr nvddr requested review from aristarkhovNV, jiwenc-nv and rwiltz and removed request for jiwenc-nv April 10, 2026 21:20
@nvddr nvddr enabled auto-merge (rebase) April 10, 2026 22:04
@nvddr nvddr disabled auto-merge April 13, 2026 16:25
@nvddr nvddr merged commit b041aa5 into release/1.1.x Apr 13, 2026
29 checks passed
@nvddr nvddr deleted the devdeepr/cherryPickNumpy branch April 13, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants