Improve performance of request_metadata logic#2378
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
fb37c1f to
54e69b7
Compare
b4d68aa to
786b9f0
Compare
78fa9c8 to
d4d4f6f
Compare
f27823f to
c7124fe
Compare
c7124fe to
bffbb99
Compare
bffbb99 to
219f5fd
Compare
7b1c2a2 to
a4cd708
Compare
a4cd708 to
83c5f69
Compare
mathemakitten
approved these changes
Dec 5, 2025
Contributor
Author
|
/ok to test 5b2bb81 |
kvareddy
reviewed
Dec 6, 2025
lmcafee-nvidia
approved these changes
Dec 8, 2025
kvareddy
approved these changes
Dec 8, 2025
shanmugamr1992
approved these changes
Dec 8, 2025
This reverts commit 9e216c4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
The current dynamic sampling code relies on code that surrounds the
request_metadatatensor in the dynamic context.Profiling, and A/B
timeittesting, shows that thisrequest_metadatacode is poorly optimized.This PR will address 3 issues found by @mathemakitten
non_blocking=True.torch.uniqueis orders of magnitude slower than doing it via list comprehension.3. In order to fix 1) and 2), the "hashed sampling parameters" tracked metadata must be resurrected.BENCHMARK INFO:
81.77, with expected noise of +/- 2%Split request_metadata 2D tensor into 1D slices, returns an average value of81.41, with expected noise of +/- 2%. This particular change had a risk of degrading performance, but it does not seem to do so.Avoid casting/copying request metadata, returns an average value of84.87, with expected noise of +/- 2%. This particular change was intended to improve performance, and it does.Replace tensorized bucketization with for loop, returns an average value of85.95, with expected noise of +/- 2%. This particular change was intended to improve performance, and it does.Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.