FlashInfer sampling#2456
Merged
Merged
Conversation
This was referenced Dec 7, 2025
tdene
force-pushed
the
tde/flashinfer_sampling
branch
from
b8558aa to
3c9fa91
Compare
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
tdene
force-pushed
the
tde/flashinfer_sampling
branch
6 times, most recently
from
dd26f3c to
84f84de
Compare
tdene
force-pushed
the
tde/flashinfer_sampling
branch
9 times, most recently
from
8f8fede to
39cd9ff
Compare
tdene
force-pushed
the
tde/flashinfer_sampling
branch
from
310037b to
329a85d
Compare
5 tasks
tdene
force-pushed
the
tde/flashinfer_sampling
branch
from
329a85d to
f8549dc
Compare
Co-Authored-By: Keshav Santhanam <ksanthanam@nvidia.com>
Co-Authored-By: Keshav Santhanam <ksanthanam@nvidia.com>
tdene
force-pushed
the
tde/flashinfer_sampling
branch
from
d1cfd43 to
de5c56d
Compare
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25329525317 |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
ko3n1g
approved these changes
May 4, 2026
Contributor
Author
|
/ok to test e580bde |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25344830114 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25346979513 |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25351891254 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25355425973 |
Andron00e
pushed a commit
to Andron00e/Megatron-LM
that referenced
this pull request
May 28, 2026
…ync-2026-05 Upstream tip: 932d9ee (Add periodic GPU sniff tests, 2026-05-07). Conflict resolution: - 13 modify/delete conflicts in .github/* and skills/*: kept deletion (matches policy from c037427 removing upstream-NVIDIA CI machinery not relevant to this fork). - AGENTS.md content conflict: kept fork version (skills/contributing sections from upstream don't apply since the directories were removed). - New upstream additions matching the same removal policy were dropped: .claude/settings.json, .github/workflows/nightly-sync-main-to-dev.yml, skills/{cicd,linting-and-formatting,nightly-sync,run-on-slurm,testing, update-golden-values}/SKILL.md. - SECURITY.md (new from upstream): kept (generic security policy). Verified post-merge: - pretrain_gpt.py logging-patch hook intact (lines 405-408). - megatron/core/optimizer/__init__.py emerging_optimizers + muon logic intact. - megatron/training/arguments.py custom muon flags intact (lines 2297-2309). Notable upstream changes pulled in: - Removed legacy transformer + legacy GPT modules (NVIDIA#4207, NVIDIA#4322). - Docker base image bump to 26.04-py3 (NVIDIA#4611). - Inference fixes (vLLM grouped GEMM NVIDIA#4566, FlashInfer sampling NVIDIA#2456, EP sync NVIDIA#4607, MoE dispatcher fixes NVIDIA#4576). - Gradient corruption fix with layerwise param all-gather overlap (NVIDIA#4609). - Hybrid model + Flextron + GPU sniff tests + named validation sets + fault injection + InJob restart.
yhgalaxy
pushed a commit
to yhgalaxy/Megatron-LM
that referenced
this pull request
Jun 17, 2026
Co-authored-by: Keshav Santhanam <ksanthanam@nvidia.com> Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker
pushed a commit
to jon-barker/Megatron-LM
that referenced
this pull request
Jul 10, 2026
Co-authored-by: Keshav Santhanam <ksanthanam@nvidia.com> Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.