FA4 TEDotProductAttention#4375
Closed
bbuschkaemper wants to merge 4 commits into
Closed
Conversation
…FA3. Signed-off-by: Björn Buschkämper <bjoern.buschkaemper@gmail.com>
Signed-off-by: Björn Buschkämper <bjoern.buschkaemper@gmail.com>
There was a problem hiding this comment.
Pull request overview
Updates Megatron-LM’s pinned TransformerEngine source to a commit that includes FA4 support, and broadens batch-invariance unit tests to run with either FlashAttention-3 or FlashAttention-4 available.
Changes:
- Bump
transformer-enginegit revision (and correspondinguv.lock) to a FA4-capable commit. - Update BIK unit tests’ skip conditions to accept FA3 or FA4 availability.
- Regenerate
uv.lockwith updated dependency metadata.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pyproject.toml |
Updates the transformer-engine git rev used by uv. |
uv.lock |
Updates locked TE version and dependency metadata; lockfile markers changed broadly. |
tests/unit_tests/transformer/test_te_layers_batch_invariant.py |
Adds FA4 availability detection and expands skip condition to allow FA3 or FA4. |
tests/unit_tests/models/test_gpt_model_batch_invariant.py |
Adds FA4 availability detection and expands skip condition to allow FA3 or FA4. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Hey @bbuschkaemper, we will bump TE soon once we are sure & ready to do so. In the meantime, users can still use the CUDNN Fused backend which provides similar performance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Bumps TE version to the merged FA4 support PR, allowing TEDotProductAttention to use FA4. Fixes unit tests that rely on FA3 to also support FA4. Possible related to #4186
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.