Skip to content

ci: Update workflow to use same commit for building docker image and running tests#4787

Open
balasaajay wants to merge 1 commit into
NVIDIA:mainfrom
balasaajay:aut-484
Open

ci: Update workflow to use same commit for building docker image and running tests#4787
balasaajay wants to merge 1 commit into
NVIDIA:mainfrom
balasaajay:aut-484

Conversation

@balasaajay
Copy link
Copy Markdown
Contributor

What does this PR do ?

Update workflow by introducing a SHA resolution step to ensure consistent commit references across jobs. This replaces the previous method of obtaining the merge commit SHA and updates downstream jobs to use the resolved SHA from the configure step.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

…nsistent commit references across jobs. This replaces the previous method of obtaining the merge commit SHA and updates downstream jobs to use the resolved SHA from the configure step.
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 13, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@balasaajay
Copy link
Copy Markdown
Contributor Author

/ok to test e7c6ffe

@balasaajay balasaajay changed the title ci: Update workflow by introducing a SHA resolution step ci: Update workflow to use same commit for building docker image and running tests May 13, 2026
@balasaajay balasaajay marked this pull request as ready for review May 13, 2026 22:26
@balasaajay balasaajay requested a review from a team as a code owner May 13, 2026 22:27
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team May 13, 2026 22:27
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label May 13, 2026
@balasaajay balasaajay added this pull request to the merge queue May 13, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25830877082

@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25831006107

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants