Commit 645a545
committed
Split credential setup out of slurm-setup.md into credentials.md
Addresses three overlapping review comments on slurm-setup.md:62
from PR #1239:
- @mxinO: NGC/HF/Docker tokens aren't SLURM-specific — wanted a
general credential setup guide referenced from multiple skills.
- CodeRabbit: `$oauthtoken` needs to be called out as a literal NGC
login string, not a shell variable to substitute.
- Copilot: the previous snippet overwrote `~/.config/enroot/.credentials`
unconditionally, clobbering entries for other registries.
New `skills/common/credentials.md` covers HF_TOKEN, NGC API key (Docker
+ enroot paths), and Docker Hub. The NGC/enroot block uses an
append-if-missing pattern (`grep -q ... || echo ... >>`) and spells
out that `$oauthtoken` is a literal, kept unexpanded via single quotes.
`slurm-setup.md` now keeps only the pyxis-specific signpost — one
paragraph pointing at `credentials.md` for the actual setup.
Signed-off-by: Zhiyu Cheng <zhiyuc@nvidia.com>1 parent 31c4fe8 commit 645a545
2 files changed
Lines changed: 61 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
| 56 | + | |
67 | 57 | | |
68 | 58 | | |
69 | 59 | | |
| |||
0 commit comments