Skip to content

Commit 8805b39

Browse files
committed
fixing docker permission for vllm
Signed-off-by: Kinjal Patel <kinjalpravin@nvidia.com>
1 parent d2994cd commit 8805b39

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/gpu_tests.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,11 @@ jobs:
5858
timeout-minutes: ${{ matrix.timeout }}
5959
container:
6060
image: ${{ matrix.container_image }}
61+
# NGC creds only for ``nvcr.io/*`` images; ``docker.io/*`` is anonymous-pull.
62+
# Empty username/password short-circuits the runner's ``docker login`` step.
6163
credentials:
62-
username: $oauthtoken
63-
password: ${{ secrets.NGC_API_KEY }}
64+
username: ${{ startsWith(matrix.container_image, 'nvcr.io/') && '$oauthtoken' || '' }}
65+
password: ${{ startsWith(matrix.container_image, 'nvcr.io/') && secrets.NGC_API_KEY || '' }}
6466
env:
6567
GIT_DEPTH: 1000 # For correct version
6668
PIP_CONSTRAINT: "" # Disable pip constraint for upgrading packages

0 commit comments

Comments
 (0)