Skip to content

Commit 9cb309b

Browse files
committed
Delete end-to-end-workflow.md per review feedback
Reviewers on PR #1239 (kaix-nv, mxinO) flagged the e2e workflow doc as unnecessary: the skill descriptions already route Claude to chain PTQ, deployment, and evaluation skills, and the content duplicated workspace-management.md or lived better inside the evaluation skill's nel-ci-guide.md references. Removes the file and its three cross-references (evaluation/SKILL.md, ptq/SKILL.md, workspace-management.md). The "carry PTQ patches forward to deploy/eval" insight is preserved as a one-liner in evaluation/SKILL.md. Signed-off-by: Zhiyu Cheng <zhiyuc@nvidia.com>
1 parent 03dfca7 commit 9cb309b

4 files changed

Lines changed: 2 additions & 74 deletions

File tree

.claude/skills/common/end-to-end-workflow.md

Lines changed: 0 additions & 70 deletions
This file was deleted.

.claude/skills/common/workspace-management.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,6 @@ workspaces/model-name-format/
105105
logs/ ← All: SLURM job logs
106106
```
107107

108-
See `skills/common/end-to-end-workflow.md` for the full pipeline.
109-
110108
## Example Flow
111109

112110
```text

.claude/skills/evaluation/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ You're an expert in NeMo Evaluator Launcher! Guide the user through creating pro
1616

1717
If `MODELOPT_WORKSPACE_ROOT` is set, read `skills/common/workspace-management.md`. Check for existing workspaces — especially if evaluating a model from a prior PTQ or deployment step. Reuse the existing workspace so you have access to the quantized checkpoint and any code modifications.
1818

19-
This skill is often the final stage of the PTQ → Deploy → Eval pipeline. If the model required runtime patches during deployment (transformers upgrade, framework source fixes), carry those patches into the NEL config via `deployment.command`. See `skills/common/end-to-end-workflow.md` for the full pipeline.
19+
This skill is often the final stage of the PTQ → Deploy → Eval pipeline. If the model required runtime patches during deployment (transformers upgrade, framework source fixes), carry those patches into the NEL config via `deployment.command`.
2020

2121
### Workflow
2222

.claude/skills/ptq/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ Report the path and size to the user.
135135

136136
Validate the exported checkpoint's quantization pattern matches the recipe. Quantization config patterns can silently miss layers if the model uses non-standard naming (e.g., Gemma4 `experts.*` missed by `*mlp*` patterns) — this only surfaces later as deployment failures. Read `references/checkpoint-validation.md` for the validation script, expected patterns per recipe, and common pattern gaps.
137137

138-
**Next steps**: If the user wants to deploy or evaluate the quantized checkpoint, use the **deployment** or **evaluation** skill. The checkpoint workspace carries over — see `skills/common/end-to-end-workflow.md` for the full PTQ → Deploy → Eval pipeline. If the model required patches during PTQ (e.g., transformers upgrade), the same fixes will likely be needed at deployment and evaluation time.
138+
**Next steps**: If the user wants to deploy or evaluate the quantized checkpoint, use the **deployment** or **evaluation** skill. The checkpoint workspace carries over. If the model required patches during PTQ (e.g., transformers upgrade), the same fixes will likely be needed at deployment and evaluation time.
139139

140140
## Key API Rules
141141

0 commit comments

Comments
 (0)