Skip to content

Commit dcc0787

Browse files
committed
resolve review comments
Signed-off-by: Shengliang Xu <shengliangx@nvidia.com>
1 parent caab3d2 commit dcc0787

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

tools/precommit/normalize_yaml_ext.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,23 @@
2929

3030
def main() -> int:
3131
"""Rename .yml files to .yaml, exit 1 if any were renamed."""
32-
renamed = []
32+
renamed: list[tuple[Path, Path]] = []
33+
collisions: list[tuple[Path, Path]] = []
3334
for f in sys.argv[1:]:
3435
path = Path(f)
3536
if path.suffix == ".yml" and path.is_file():
3637
new_path = path.with_suffix(".yaml")
38+
if new_path.exists():
39+
collisions.append((path, new_path))
40+
continue
3741
os.rename(path, new_path)
3842
renamed.append((path, new_path))
3943

44+
if collisions:
45+
for old, new in collisions:
46+
print(f"ERROR: Cannot rename {old} -> {new} (destination already exists)")
47+
return 1
48+
4049
if renamed:
4150
for old, new in renamed:
4251
print(f"Renamed: {old} -> {new}")

0 commit comments

Comments
 (0)