fix lm-eval version conflict in puzzletron requirements#1257
fix lm-eval version conflict in puzzletron requirements#1257j-rausch wants to merge 3 commits intofeature/puzzletronfrom
Conversation
…dd version compat warning to lm_eval_hf.py Signed-off-by: jrausch <jrausch@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR downgrades the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
|
/ok to test 6bbb9d6 |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/puzzletron #1257 +/- ##
===================================================
Coverage 76.44% 76.45%
===================================================
Files 454 454
Lines 47913 47913
===================================================
+ Hits 36629 36632 +3
+ Misses 11284 11281 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Summary
lm_eval_hf.py, which monkey-patchesHFLM.create_from_arg_objexamples/puzzletron/requirements.txtfromlm-eval==0.4.10tolm-eval==0.4.8to matchexamples/llm_eval/requirements.txtlm_eval_hf.pyfor early detection if versions drift againSummary by CodeRabbit