From 909ced4f9486a4caa4863842de5d4d6da348362f Mon Sep 17 00:00:00 2001 From: h-guo18 <67671475+h-guo18@users.noreply.github.com> Date: Tue, 26 May 2026 22:55:54 +0000 Subject: [PATCH] docs(launcher): scope CLAUDE.md "new model config" section to Megatron-LM PTQ MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The section is Megatron-LM PTQ-specific (env vars MLM_MODEL_CFG / QUANT_CFG only apply to that pipeline), but the generic title was being read as universal — e.g. by CodeRabbit, which flagged a streaming EAGLE3 yaml for missing those vars. Retitle and add a lead-in pointing other pipelines to sibling yamls. Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> --- tools/launcher/CLAUDE.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/launcher/CLAUDE.md b/tools/launcher/CLAUDE.md index 70bd56f3700..750f42cc7a0 100644 --- a/tools/launcher/CLAUDE.md +++ b/tools/launcher/CLAUDE.md @@ -84,7 +84,11 @@ launch.py → imports core.py + slurm_config.py - `report_versions(base_dir)` — prints git commit/branch for launcher + submodules - `get_default_env(title)` — returns `(slurm_env, local_env)` dicts -## Adding a New Model Config +## Adding a New Megatron-LM PTQ Model Config + +Steps below apply to `examples///megatron_lm_ptq.yaml`. Other pipelines +(HF PTQ, HF / offline / streaming EAGLE3, dflash) use different env vars — copy +the closest sibling yaml in the same directory as a starting point. 1. Create `examples///megatron_lm_ptq.yaml` following the format above 2. Set `MLM_MODEL_CFG` to the HuggingFace repo ID