-
Notifications
You must be signed in to change notification settings - Fork 451
[skills] Fix eval/deploy defaults for NVFP4-on-Blackwell + nemo-skills evals #1595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f8096a6
[skills] Fix eval/deploy defaults for NVFP4-on-Blackwell + nemo-skill…
Edwardf0t1 0d7595d
[skills] evaluation: prefer checkpoint_path over hf_model_handle
Edwardf0t1 2fa127e
[skills] address PR #1595 review feedback
Edwardf0t1 beaad18
[skills] address PR #1595 second-pass review (cjluo-nv)
Edwardf0t1 9ccf032
[skills] gres: defer to #1599's internal/slurm/<cluster>, keep one-li…
Edwardf0t1 96408be
[skills] de-dup served-model-name rationale (single-source to example)
Edwardf0t1 81fed42
[skills] de-dup hf_model_handle rationale (single-source to example)
Edwardf0t1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
CUDA error: no kernel image is available for execution on the device, description and fix seem like a good candidate for the debugging playbook (/ shared memory) that I attempted in 1493. Perhaps we can restart the conversation on how to best develop shared memory for the agent?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 — this is a good playbook candidate. I didn't fold it into shared memory here to keep the PR scoped, but happy to restart the #1493 discussion and migrate the "no kernel image → cu130" finding into the debugging playbook.