Skip to content

[24.04_linux-nvidia-6.17-next] CVE-2026-31431: crypto/algif_aead in-place operation enables page-cache write (Copy Fail)#402

Closed
ianm-nv wants to merge 1 commit into
NVIDIA:24.04_linux-nvidia-6.17-nextfrom
ianm-nv:24.04_linux-nvidia-6.17-next+CVE-2026-31431
Closed

[24.04_linux-nvidia-6.17-next] CVE-2026-31431: crypto/algif_aead in-place operation enables page-cache write (Copy Fail)#402
ianm-nv wants to merge 1 commit into
NVIDIA:24.04_linux-nvidia-6.17-nextfrom
ianm-nv:24.04_linux-nvidia-6.17-next+CVE-2026-31431

Conversation

@ianm-nv
Copy link
Copy Markdown
Collaborator

@ianm-nv ianm-nv commented Apr 30, 2026

Reference: https://copy.fail/

crypto: algif_aead - Revert to operating out-of-place

BugLink: https://bugs.launchpad.net/bugs/2150789

This mostly reverts commit 72548b0 except for the copying of the associated data.

There is no benefit in operating in-place in algif_aead since the source and destination come from different mappings. Get rid of all the complexity added for in-place operation and just copy the AD directly.

Fixes: 72548b0 ("crypto: algif_aead - copy AAD from src to dst")
Reported-by: Taeyang Lee 0wn@theori.io
(cherry picked from commit a664bf3)
CVE-2026-31431

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

PR Validation Report

Patchscan ✅ No Missing Fixes

All cherry-picked commits checked — no missing upstream fixes found.

PR Lint ✅ All checks passed

Details
Checking 1 commits...

Cherry-pick digest:
┌──────────────┬───────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐
│ Local        │ Referenced upstream / Patch subject           │ Patch-ID   │ Subject │ SoB chain                 │
├──────────────┼───────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤
│ de4425644e5f │ a664bf3d603d                                  │ match      │ match   │ preserved + ianm added    │
└──────────────┴───────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘

Lint: all checks passed.

BugLink: https://bugs.launchpad.net/bugs/2150789

This mostly reverts commit 72548b0 except for the copying of
the associated data.

There is no benefit in operating in-place in algif_aead since the
source and destination come from different mappings.  Get rid of
all the complexity added for in-place operation and just copy the
AD directly.

Fixes: 72548b0 ("crypto: algif_aead - copy AAD from src to dst")
Reported-by: Taeyang Lee <0wn@theori.io>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
(cherry picked from commit a664bf3)
CVE-2026-31431
Signed-off-by: Ian May <ianm@nvidia.com>
@ianm-nv ianm-nv force-pushed the 24.04_linux-nvidia-6.17-next+CVE-2026-31431 branch from cc274ff to de44256 Compare April 30, 2026 22:11
@nvmochs nvmochs self-requested a review April 30, 2026 22:26
Copy link
Copy Markdown
Collaborator

@nvmochs nvmochs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this is a clean pick. No issues with this backport.

Acked-by: Matthew R. Ochs <mochs@nvidia.com>

@jamieNguyenNVIDIA
Copy link
Copy Markdown
Collaborator

Acked-by: Jamie Nguyen <jamien@nvidia.com>

@clsotog
Copy link
Copy Markdown
Collaborator

clsotog commented Apr 30, 2026

Acked-by: Carol L Soto <csoto@nvidia.com>

@nvmochs
Copy link
Copy Markdown
Collaborator

nvmochs commented Apr 30, 2026

Merged, closing PR.

cc4d2bf72772 crypto: algif_aead - Revert to operating out-of-place

@nvmochs nvmochs closed this Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants