Skip to content

Commit 8a04939

Browse files
authored
chore: Set minimum Node.js version to 24 (#146)
#### Overview Set minimum Node.js version to 24, since that is the version we use in CI. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details * Remove `*.profraw` files from root of the repo and `integrations/openclaw/` #### Where should the reviewer start? - justfile ## Summary by CodeRabbit * **Chores** * Enhanced local cleanup to remove profiling (.profraw) files. * Updated development dependency for Node type definitions. * **Documentation** * Raised the documented minimum Node.js requirement to version 24 across guides and READMEs. [![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/NVIDIA/NeMo-Relay/pull/146?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - https://github.com/Salonijain27 - Will Killian (https://github.com/willkill07) URL: #146
1 parent d288659 commit 8a04939

11 files changed

Lines changed: 24 additions & 37 deletions

File tree

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ Install the tools needed for the surfaces you touch. For a full repository valid
5252
|---|---|---|
5353
| Rust | Docs minimum is 1.86 or newer; the repo pins the active toolchain in `rust-toolchain.toml` | Rust core, native bindings, FFI, WebAssembly |
5454
| Python | 3.11 or newer | Python package, PyO3 builds, docs tooling |
55-
| Node.js | 20 or newer, with npm | Node.js binding, WebAssembly JS tests, generated API docs |
55+
| Node.js | 24 or newer, with npm | Node.js binding, WebAssembly JS tests, generated API docs |
5656
| Go | 1.21 or newer | Experimental Go binding |
5757
| `uv` | Current project workflow tool | Python environments, docs dependencies, pre-commit |
5858
| `just` | 1.40 or newer | Canonical build, test, docs, package task runner |

ATTRIBUTIONS-Node.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13694,7 +13694,7 @@ MIT License
1369413694
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
1369513695
SOFTWARE```
1369613696

13697-
## @types/node - 20.19.40
13697+
## @types/node - 24.12.4
1369813698
**Repository URL**: https://github.com/DefinitelyTyped/DefinitelyTyped
1369913699
**License Type(s)**: MIT
1370013700
### License: https://spdx.org/licenses/MIT.html
@@ -26024,7 +26024,7 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
2602426024
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
2602526025
SOFTWARE.```
2602626026

26027-
## undici-types - 6.21.0
26027+
## undici-types - 7.16.0
2602826028
**Repository URL**: https://github.com/nodejs/undici
2602926029
**License Type(s)**: MIT
2603026030
### License: https://spdx.org/licenses/MIT.html

crates/node/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ should install it from npm rather than depend on the Rust crate directly.
3838

3939
## What You Get
4040

41-
-**npm package for Node.js**: A Node.js 20 or newer package backed by a
41+
-**npm package for Node.js**: A Node.js 24 or newer package backed by a
4242
napi-rs native extension.
4343
-**Managed tool and LLM execution**: Helpers that emit lifecycle events and
4444
run middleware in a consistent order.
@@ -51,7 +51,7 @@ should install it from npm rather than depend on the Rust crate directly.
5151

5252
## Installation
5353

54-
Install the npm package in a Node.js 20 or newer project:
54+
Install the npm package in a Node.js 24 or newer project:
5555

5656
```bash
5757
npm install nemo-relay-node

crates/node/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
}
4848
},
4949
"engines": {
50-
"node": ">=20.0.0"
50+
"node": ">=24.0.0"
5151
},
5252
"napi": {
5353
"name": "nemo-relay",

crates/wasm/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "nemo-relay-wasm",
33
"private": true,
44
"engines": {
5-
"node": ">=20.0.0"
5+
"node": ">=24.0.0"
66
},
77
"scripts": {
88
"build:pkg": "node scripts/build_pkg.mjs",

docs/getting-started/prerequisites.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Install the tooling for the binding you plan to use.
1111
|---|---|---|
1212
| Rust | 1.86 or newer | Rust builds, local workspace builds, and the Rust core runtime |
1313
| Python | 3.11 or newer | Python bindings, Python tests, and docs tooling |
14-
| Node.js | 20 or newer | Node.js bindings and generated Node.js API docs |
14+
| Node.js | 24 or newer | Node.js bindings and generated Node.js API docs |
1515
| `uv` | see [Development Setup](../contribute/development-setup.md) | Python environments, docs builds, and repository setup |
1616
| `just` | see [Development Setup](../contribute/development-setup.md) | Repository development, test, build, and docs task aliases |
1717

docs/reference/api/nodejs/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ These pages are generated from the exported TypeScript declaration surfaces in `
1212
This summary lists the package identity and support status for the binding.
1313

1414
- Package name: `nemo-relay-node`
15-
- Runtime requirement: Node.js `>=20`
15+
- Runtime requirement: Node.js `>=24`
1616
- Local development path: `crates/node`
1717

1818
The Node.js binding is built with `napi-rs`. The package root exports the core

integrations/openclaw/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
"nemo-relay-node": "0.3.0"
6767
},
6868
"devDependencies": {
69-
"@types/node": "^20.19.0",
69+
"@types/node": "^24.0.0",
7070
"typescript": "^5.8.2"
7171
},
7272
"license": "Apache-2.0"

justfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -782,6 +782,7 @@ clean:
782782
rm -rf \
783783
.coverage \
784784
.pytest_cache \
785+
*.profraw \
785786
crates/**/*.profraw \
786787
crates/node/*.node \
787788
crates/node/coverage \
@@ -792,6 +793,7 @@ clean:
792793
crates/wasm/node_modules \
793794
crates/wasm/pkg-test/ \
794795
crates/wasm/pkg/ \
796+
integrations/openclaw/*.profraw \
795797
integrations/openclaw/.test-dist \
796798
integrations/openclaw/dist \
797799
integrations/openclaw/node_modules \

package-lock.json

Lines changed: 11 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)