examples: Helm metadata-filter notebook path (PR #2195 follow-up, @jioffe502)#2261
examples: Helm metadata-filter notebook path (PR #2195 follow-up, @jioffe502)#2261kheiss-uwzoo wants to merge 1 commit into
Conversation
Follow-up to PR NVIDIA#2195: document job-based sidecar ingest for Helm deployments in the metadata filtering notebook. Part A keeps local GraphIngestor flow; Part B outlines POST /v1/ingest/sidecar and meta_dataframe_id for assignees to complete.
|
Agreed — this is not ready for review yet. It was opened as a tracking scaffold for the #2195 follow-up: Part B outlines the Helm / service flow (POST /v1/ingest/sidecar, job-based ingest, meta_dataframe_id) but does not yet include runnable cells. @jioffe502 and @jdye64 still need to add the executable RetrieverServiceClient / ServiceIngestor path. The large diff is mostly notebook JSON re-serialization; the substantive change is the Part A / Part B structure and the Part B outline. Marking as draft until the Helm cells land. Sorry for the noise — should have opened it that way initially. |
|
@randerzander: you don't need to update the notebook, fwiw. Jacob will do that and actually test that it's working w/ the service deployment 🙂 |
|
Handing off per @randerzander: docs is done on #2195 / \�dbs.md. This draft is for @jioffe502 to implement and test Part B against a service deployment — no further notebook commits expected from docs. Jacob may reset or replace the opening scaffold commit. |
|
Adding query filter options for retriever in #2258 once that merges will provide and update this notebook example |
Summary
Eng follow-up to PR #2195: add Helm / retriever-service guidance to
examples/nemo_retriever_retriever_query_metadata_filter.ipynb.vdbs.md#metadata-and-filteringstays a notebook pointer only — no sidecar / service prose on the docs page.Owner: @jioffe502 (per @randerzander). cc @jdye64 if pairing is needed.
Reviewer note (@randerzander)
Docs does not need further commits on this branch. Jacob may replace or reset the opening scaffold commit when implementing.
Scope (@jioffe502)
POST /v1/ingest/sidecar→meta_dataframe_idonvdb_upload_params→ job-basedPOST /v1/ingest/job+ document upload → filteredRetriever.queryRetrieverServiceClient/ServiceIngestoragainst a Helm deploymentmetadataJSON,wherefilters workRelated
POST /v1/ingest/sidecar,POST /v1/ingest/job,test_service_sidecar.pyTest plan
meta_a,meta_b) appear in LanceDBmetadataJSON andwherefilters work