Second draft of Korean Cardinal ITN#284
Merged
mgrafu merged 11 commits intoNVIDIA:ko_itn_staging_v1from Jun 10, 2025
Merged
Conversation
Sparrowhawk testing is not done yet. Signed-off-by: hmlee245 <hmlee245@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: hmlee245 <hmlee245@gmail.com>
Signed-off-by: hmlee245 <hmlee245@gmail.com>
for more information, see https://pre-commit.ci
changes made to 9f7e876. Signed-off-by: hmlee245 <hmlee245@gmail.com>
for more information, see https://pre-commit.ci
Author
|
Comments that still needs to be reviewed from PR #281 |
mgrafu
reviewed
May 23, 2025
nemo_text_processing/inverse_text_normalization/ko/taggers/cardinal.py
Outdated
Show resolved
Hide resolved
mgrafu
reviewed
May 23, 2025
nemo_text_processing/inverse_text_normalization/ko/data/numbers/thousands.tsv
Outdated
Show resolved
Hide resolved
mgrafu
reviewed
May 23, 2025
nemo_text_processing/inverse_text_normalization/ko/taggers/cardinal.py
Outdated
Show resolved
Hide resolved
mgrafu
reviewed
May 23, 2025
mgrafu
reviewed
May 23, 2025
nemo_text_processing/inverse_text_normalization/ko/taggers/cardinal.py
Outdated
Show resolved
Hide resolved
mgrafu
reviewed
May 23, 2025
nemo_text_processing/inverse_text_normalization/ko/taggers/cardinal.py
Outdated
Show resolved
Hide resolved
… test cases Signed-off-by: hmlee245 <hmlee245@gmail.com>
…45/NeMo-text-processing into Draft-Version2/Korean-ITN Signed-off-by: hmlee245 <hmlee245@gmail.com>
Signed-off-by: hmlee245 <hmlee245@gmail.com>
for more information, see https://pre-commit.ci
bbae0312
pushed a commit
to bbae0312/NeMo-text-processing
that referenced
this pull request
Mar 6, 2026
* First draft of Korean Cardinal ITN Sparrowhawk testing is not done yet. Signed-off-by: hmlee245 <hmlee245@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixing all the feedbacks Signed-off-by: hmlee245 <hmlee245@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * This reverts commit f893d89, reversing changes made to 9f7e876. Signed-off-by: hmlee245 <hmlee245@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * third draft of korean ITN work. Mainly fixing minor issues and adding test cases Signed-off-by: hmlee245 <hmlee245@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: hmlee245 <hmlee245@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sparrowhawk testing is not done yet.
This PR is aiming to have no DCO errors. First draft will be deleted due to force signing on a unrelated work and kept signing on it.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.