Commit 56ae053
## Summary
`04-landlock-readonly.sh` has exited 127 on **every nightly since April
8** when it was added in PR #1121. This is one of the three root causes
keeping the nightly E2E red for 24+ consecutive days.
## Root Cause
The `sandbox_exec()` helper calls:
```bash
openshell sandbox exec "$SANDBOX_NAME" -- bash -c "..."
```
But `openshell 0.0.26` requires the `--name` flag:
```bash
openshell sandbox exec --name "$SANDBOX_NAME" -- bash -c "..."
```
Without `--name`, the sandbox name (`e2e-cloud-experimental`) is parsed
as the **command to execute**, producing `command not found` → exit 127.
## Fix
One-line change in `sandbox_exec()`:
```diff
- openshell sandbox exec "$SANDBOX_NAME" -- bash -c "$1" 2>&1
+ openshell sandbox exec --name "$SANDBOX_NAME" -- bash -c "$1" 2>&1
```
## Verification
Reproduced and verified the fix on a DGX Spark running the E2E suite:
- Before fix: `04-landlock-readonly: EXIT CODE: 127`
- After fix: `openshell sandbox exec --name e2e-debug -- echo "hello
from sandbox"` → `hello from sandbox`
Closes #1851
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Chores**
* Standardized how sandbox instances are invoked in end-to-end tests to
ensure consistent execution and verification across checks and rebuild
scenarios.
* Internal test-only changes; no user-facing behavior, API, or public
interface modifications.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: Aaron Erickson <aerickson@nvidia.com>
1 parent aaae417 commit 56ae053
2 files changed
Lines changed: 4 additions & 4 deletions
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
99 | | - | |
| 99 | + | |
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
| 104 | + | |
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
147 | | - | |
| 147 | + | |
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
| |||
0 commit comments