Skip to content

Commit 6ae8328

Browse files
fix(test/docs): address CodeRabbit follow-ups on previous two commits
- test/e2e/test-inference-routing.sh — drop the five NEMOCLAW_SANDBOX_NAME additions from the previous commit. Each block already had the right name set on an earlier line ($SANDBOX_NAME / $sbx_name); the redundant trailing assignments would have last-won under bash inline-assignment semantics and onboarded a different sandbox than the one the test then SSHes into and asserts on. - test/e2e/brev-e2e.test.ts — switch the sandbox name from "e2e-brev" back to "e2e-test" so the launchable onboard path keeps matching the downstream connectivity / health / destroy checks at lines 552, 591, 626, 703. - docs/reference/troubleshooting.md — credential rotation example appends --yes-i-accept-third-party-software so the copy-paste form is complete. Signed-off-by: latenighthackathon <latenighthackathon@users.noreply.github.com>
1 parent 4bc1d2e commit 6ae8328

3 files changed

Lines changed: 2 additions & 7 deletions

File tree

docs/reference/troubleshooting.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ If you suspect a sandbox is still using a stale token, re-run onboarding so
350350
the credential check runs:
351351

352352
```console
353-
$ NEMOCLAW_SANDBOX_NAME=my-assistant nemoclaw onboard --non-interactive
353+
$ NEMOCLAW_SANDBOX_NAME=my-assistant nemoclaw onboard --non-interactive --yes-i-accept-third-party-software
354354
```
355355

356356
### Sandbox creation killed by OOM (exit 137)

test/e2e/brev-e2e.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,7 @@ function pollForSandboxReady(elapsed: () => string): void {
511511
[
512512
`source ~/.nvm/nvm.sh 2>/dev/null || true`,
513513
`cd ${remoteDir}`,
514-
`NEMOCLAW_SANDBOX_NAME="e2e-brev" nohup nemoclaw onboard --non-interactive </dev/null >/tmp/nemoclaw-onboard.log 2>&1 & disown`,
514+
`NEMOCLAW_SANDBOX_NAME="e2e-test" nohup nemoclaw onboard --non-interactive </dev/null >/tmp/nemoclaw-onboard.log 2>&1 & disown`,
515515
`sleep 2`,
516516
`echo "onboard launched"`,
517517
].join(" && "),

test/e2e/test-inference-routing.sh

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,6 @@ test_inf_05_credential_isolation() {
205205
NEMOCLAW_NON_INTERACTIVE=1 \
206206
NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE=1 \
207207
NEMOCLAW_POLICY_TIER="open" \
208-
NEMOCLAW_SANDBOX_NAME="e2e-inf-routing" \
209208
nemoclaw onboard --non-interactive --yes-i-accept-third-party-software \
210209
2>&1 | redact_stream "$real_key" | tee -a "$LOG_FILE" || onboard_exit=$?
211210
if [[ $onboard_exit -ne 0 ]]; then
@@ -367,7 +366,6 @@ test_inf_07_unreachable_endpoint() {
367366
NEMOCLAW_ENDPOINT_URL="https://nemoclaw-e2e.invalid/v1" \
368367
NEMOCLAW_MODEL="test-model" \
369368
COMPATIBLE_API_KEY="fake-key-for-unreachable-test" \
370-
NEMOCLAW_SANDBOX_NAME="e2e-unreachable" \
371369
run_with_timeout 120 nemoclaw onboard --non-interactive --yes-i-accept-third-party-software \
372370
2>&1) || exit_code=$?
373371

@@ -435,7 +433,6 @@ test_inf_02_openai() {
435433
NEMOCLAW_PROVIDER="openai" \
436434
NEMOCLAW_MODEL="$model" \
437435
OPENAI_API_KEY="$api_key" \
438-
NEMOCLAW_SANDBOX_NAME="e2e-inf-openai" \
439436
run_with_timeout 300 nemoclaw onboard --non-interactive --yes-i-accept-third-party-software \
440437
2>&1 | redact_stream "$api_key" | tee -a "$LOG_FILE" || onboard_exit=$?
441438

@@ -510,7 +507,6 @@ test_inf_03_anthropic() {
510507
NEMOCLAW_PROVIDER="anthropic" \
511508
NEMOCLAW_MODEL="$model" \
512509
ANTHROPIC_API_KEY="$api_key" \
513-
NEMOCLAW_SANDBOX_NAME="e2e-inf-anthropic" \
514510
run_with_timeout 300 nemoclaw onboard --non-interactive --yes-i-accept-third-party-software \
515511
2>&1 | redact_stream "$api_key" | tee -a "$LOG_FILE" || onboard_exit=$?
516512

@@ -598,7 +594,6 @@ test_inf_09_compatible_endpoint() {
598594
NEMOCLAW_ENDPOINT_URL="$endpoint_url" \
599595
NEMOCLAW_MODEL="$endpoint_model" \
600596
COMPATIBLE_API_KEY="$endpoint_key" \
601-
NEMOCLAW_SANDBOX_NAME="e2e-inf-custom" \
602597
run_with_timeout 300 nemoclaw onboard --non-interactive --yes-i-accept-third-party-software \
603598
2>&1 | redact_stream "$endpoint_key" | tee -a "$LOG_FILE" || onboard_exit=$?
604599

0 commit comments

Comments
 (0)