Skip to content

Commit aa0ff5d

Browse files
committed
[TRTLLM-12154][test] Address disagg helper naming nit
Signed-off-by: Brian Nguyen <brnguyen@nvidia.com>
1 parent 0677c20 commit aa0ff5d

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

tests/integration/defs/disaggregated/test_disaggregated.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ def setup_model_symlink(llm_venv, model_root, dest_subpath):
294294
os.symlink(model_root, dst, target_is_directory=True)
295295

296296

297-
def resolve_llm_model_path(model_path: str) -> str:
297+
def _resolve_llm_model_path(model_path: str) -> str:
298298
"""Resolve a model subpath relative to the test LLM model root."""
299299
if os.path.isabs(model_path):
300300
return model_path
@@ -510,7 +510,7 @@ def setup_disagg_cluster(
510510
if isinstance(speculative_config, dict):
511511
speculative_model = speculative_config.get("speculative_model")
512512
if speculative_model:
513-
speculative_config["speculative_model"] = resolve_llm_model_path(
513+
speculative_config["speculative_model"] = _resolve_llm_model_path(
514514
speculative_model)
515515

516516
disagg_cluster = get_default_disagg_cluster_config()
@@ -544,7 +544,7 @@ def setup_disagg_cluster(
544544
# Launch workers
545545
model = model_name or config.get("model")
546546
if model:
547-
model = resolve_llm_model_path(model)
547+
model = _resolve_llm_model_path(model)
548548
ctx_workers = []
549549
gen_workers = []
550550
disagg_server = None
@@ -2099,7 +2099,7 @@ def test_disaggregated_gpt_oss_120b_harmony(disaggregated_test_root,
20992099
def test_disaggregated_qwen3_32b_fp8(disaggregated_test_root,
21002100
disaggregated_example_root, llm_venv,
21012101
model_path):
2102-
model_dir = resolve_llm_model_path(model_path)
2102+
model_dir = _resolve_llm_model_path(model_path)
21032103
setup_model_symlink(llm_venv, model_dir, model_path)
21042104

21052105
run_disaggregated_test(disaggregated_example_root,
@@ -2140,7 +2140,7 @@ def test_disaggregated_stress_test(disaggregated_test_root,
21402140
# Unpack configuration from dataclass
21412141
model_path = test_config.model_path
21422142
test_desc = test_config.test_desc
2143-
model_dir = resolve_llm_model_path(model_path)
2143+
model_dir = _resolve_llm_model_path(model_path)
21442144
setup_model_symlink(llm_venv, model_dir, model_path)
21452145

21462146
config_file = get_test_config(test_desc, disaggregated_example_root,

0 commit comments

Comments
 (0)