[https://nvbugs/6215678][fix] Point --output-artifact-dir at a unique per-run subdir `{model}-openai-complet#14742
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR reorganizes stress test aiperf artifact output by directing profiles into model-and-concurrency-specific subdirectories rather than a shared directory. The ChangesStress Test Artifact Handling
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
d5efdbd to
b4ade65
Compare
b4ade65 to
b9c5f97
Compare
|
/bot command |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run --stage-list "A10-PyTorch-1, A10-PyTorch-2" |
|
PR_Github #53271 [ run ] triggered by Bot. Commit: |
|
PR_Github #53271 [ run ] completed with state |
|
/bot run --stage-list "A10-PyTorch-Post-Merge-1" |
|
PR_Github #53430 [ run ] triggered by Bot. Commit: |
|
PR_Github #53430 [ run ] completed with state |
b9c5f97 to
70acfe6
Compare
|
/bot run |
|
PR_Github #53463 [ run ] triggered by Bot. Commit: |
|
PR_Github #53463 [ run ] completed with state
|
70acfe6 to
ae6cfe4
Compare
|
/bot run |
|
PR_Github #54209 [ run ] triggered by Bot. Commit: |
ae6cfe4 to
e70fb7a
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #54213 [ run ] completed with state
|
e70fb7a to
4f711fd
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #54407 [ run ] triggered by Bot. Commit: |
|
PR_Github #54407 [ run ] completed with state
|
|
/bot run |
|
PR_Github #54556 [ run ] triggered by Bot. Commit: |
|
PR_Github #54556 [ run ] completed with state
|
|
/bot run |
|
PR_Github #54704 [ run ] triggered by Bot. Commit: |
|
PR_Github #54704 [ run ] completed with state
|
|
/bot run |
|
PR_Github #54775 [ run ] triggered by Bot. Commit: |
|
PR_Github #54775 [ run ] completed with state
|
4f711fd to
edae8f4
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #54814 [ run ] triggered by Bot. Commit: |
|
PR_Github #54814 [ run ] completed with state
|
…ress test aiperf was given a single shared --output-artifact-dir, so each concurrency run overwrote the previous export and no <model>-openai-completions-<...> subdir existed for extract_stress_test_metrics to parse, raising "No model directories found ...". Point --output-artifact-dir at a unique per-run subdir so every run is preserved and the directory-name parser matches. Gitignore the test-generated artifacts dir and remove the obsolete waivers. Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com> Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
edae8f4 to
0eb3bb7
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #54902 [ run ] triggered by Bot. Commit: |
|
PR_Github #54902 [ run ] completed with state
|
|
/bot run |
|
PR_Github #54958 [ run ] triggered by Bot. Commit: |
|
PR_Github #54958 [ run ] completed with state |
…ue per-run subdir `{model}-openai-complet (NVIDIA#14742)
Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Signed-off-by: GitLab CI Bot <gitlab-ci@nvidia.com>
…ue per-run subdir `{model}-openai-complet (NVIDIA#14742)
Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Signed-off-by: GitLab CI Bot <gitlab-ci@nvidia.com>
Summary
--output-artifact-dir, so each concurrency run overwrote the prior export and no<model>-openai-completions-<...>subdir existed for the directory-name parser to match.--output-artifact-dirat a unique per-run subdir{model}-openai-completions-concurrency{N}, gitignore the test-generated artifacts dir, and remove the obsolete nvbugs/6215678 waivers.Test plan
Links
Summary by CodeRabbit
Tests
Chores