[TRTLLM-13249][feat] Wave 4: add MX staged receiver cutover#15387
Conversation
|
/bot run --disable-fail-fast |
|
PR_Github #54387 [ run ] triggered by Bot. Commit: |
6d5feca to
0b3b58d
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #54483 [ run ] triggered by Bot. Commit: |
|
PR_Github #54387 [ run ] completed with state |
|
PR_Github #54483 [ run ] completed with state
|
|
/bot run --disable-fail-fast --stage-list "DGX_H100-PyTorch-2,H100_PCIe-PyTorch-Ray-1,DGX_B200-4_GPUs-PyTorch-Ray-1" |
|
PR_Github #54639 [ run ] triggered by Bot. Commit: |
|
PR_Github #54639 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #54670 [ run ] triggered by Bot. Commit: |
|
PR_Github #54670 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #57118 [ run ] triggered by Bot. Commit: |
|
PR_Github #57061 [ run ] completed with state |
|
PR_Github #57118 [ run ] completed with state
|
ef8cf45 to
45e24ee
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #57214 [ run ] triggered by Bot. Commit: |
|
PR_Github #57214 [ run ] completed with state
|
brb-nv
left a comment
There was a problem hiding this comment.
Approving changes under tensorrt_llm/_torch/models with a comment.
|
/bot run --disable-fail-fast |
|
PR_Github #57268 [ run ] triggered by Bot. Commit: |
|
PR_Github #57268 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
9d4a470 to
6c70685
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #57632 [ run ] triggered by Bot. Commit: |
|
PR_Github #57632 [ run ] completed with state |
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
6c70685 to
7f7d95c
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #57902 [ run ] triggered by Bot. Commit: |
|
PR_Github #57902 [ run ] completed with state |
Summary
Wave 4 of the staged post-load hooks rollout, stacked on #15386.
This adds the dormant MX receiver-side cutover infrastructure for consuming post-transform weights once Wave 5 teaches MX publishers to advertise that layout. Production behavior remains unchanged today: the MX post-transform signal defaults false and the per-model allow-list ships empty.
What Changed
(model_class, transform_protocol_version)allow-list entry are all required before skippingtransform_weights().ModelLoader:setup_aliases()-> mark participating modules as_weights_transformed=True->cache_derived_state(), while preserving the existing fullpost_load_weights()path for all non-allow-listed cases._source_metadata_is_post_transform()returning false until Wave 5 wires explicit MX metadata.Dependency / prerequisite stack
This PR is Wave 4 in the staged post-load hooks rollout. The foundation PRs #14770 and #14878 and upstream wave PRs #15014 and #15288 are already merged. The remaining wave PRs should merge in sequence; after each upstream wave lands, rebase the next wave onto
mainso review and CI focus on that wave's delta.Arrows point from prerequisite to dependent. PR numbers in graph nodes are clickable.
graph TD PR14770["<a href='https://github.com/NVIDIA/TensorRT-LLM/pull/14770'>#14770</a>: staged-hook contract (merged)"] PR14878["<a href='https://github.com/NVIDIA/TensorRT-LLM/pull/14878'>#14878</a>: GMS SourceIdentity gate (merged)"] PR15014["<a href='https://github.com/NVIDIA/TensorRT-LLM/pull/15014'>#15014</a>: Wave 1 aliases + GMS RO load (merged)"] PR15288["<a href='https://github.com/NVIDIA/TensorRT-LLM/pull/15288'>#15288</a>: Wave 2 Linear/Attention transforms (merged)"] PR15386["<a href='https://github.com/NVIDIA/TensorRT-LLM/pull/15386'>#15386</a>: Wave 3 MoE/Mamba staged hooks (open)"] PR15387["<a href='https://github.com/NVIDIA/TensorRT-LLM/pull/15387'>#15387</a>: Wave 4 MX receiver cutover (this PR, open)"] PR15432["<a href='https://github.com/NVIDIA/TensorRT-LLM/pull/15432'>#15432</a>: Wave 5 MX post-transform Llama receiver (open)"] VERIFY["post-migration verification / demo (planned)"] PR14770 -->|satisfied| PR15014 PR14878 -->|satisfied| PR15014 PR15014 -->|satisfied| PR15288 PR15288 -->|satisfied| PR15386 PR15386 -->|blocking| PR15387 PR15387 -->|blocking| PR15432 PR15432 -.->|planned| VERIFY classDef merged fill:#dcfce7,stroke:#16a34a,color:#14532d; classDef inflight fill:#dbeafe,stroke:#2563eb,color:#1e3a8a; classDef current fill:#ede9fe,stroke:#7c3aed,color:#3b0764,stroke-width:3px; classDef downstream fill:#f3f4f6,stroke:#6b7280,color:#374151,stroke-dasharray:5 5; linkStyle 0,1,2,3 stroke:#16a34a,stroke-width:2px; linkStyle 4,5 stroke:#ea580c,stroke-width:3px; linkStyle 6 stroke:#6b7280,stroke-width:2px,stroke-dasharray:5 5; class PR14770,PR14878,PR15014,PR15288 merged; class PR15386,PR15432 inflight; class PR15387 current; class VERIFY downstream;Immediate merge dependency for this PR: #15386 must land first; after it lands, rebase this branch onto
mainso the PR diff collapses to the Wave 4 delta.Test Plan
git diff --checkpython -m py_compile tensorrt_llm/_torch/models/checkpoints/base_checkpoint_loader.py tensorrt_llm/_torch/models/checkpoints/mx/checkpoint_loader.py tensorrt_llm/_torch/pyexecutor/model_loader.py tests/unittest/_torch/models/checkpoints/mx/test_mx_checkpoint_loader.py tests/unittest/_torch/pyexecutor/test_model_loader_mx.pypython -m pytest tests/unittest/_torch/models/checkpoints/mx/test_mx_checkpoint_loader.py tests/unittest/_torch/pyexecutor/test_model_loader_mx.py -qattempted, but blocked in this local shell becausetransformersis not installed.waive list checkandvalidate-test-listswere skipped because the hook runtime fails inscripts/check_test_list.pyonstr | Nonebefore inspecting this diff.Next Steps
Summary by CodeRabbit
Release Notes
New Features
Improvements