[https://nvbugs/6341070][fix] Fix scaffolding MajorityVoteController output handling

[KleinBlueC]

Summary by CodeRabbit

• Bug Fixes
  • Corrected how the selected majority-vote result is written back, so the chosen answer now appears in the task output as expected.
• Tests
  • Re-enabled several scaffolding-related tests that were previously skipped, increasing coverage for this workflow.
  • Enabled an additional worker generation test to run under the same conditions.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

[KleinBlueC]

/bot run --disable-fail-fast

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cdda33b9-fcc4-4618-9d99-457f333f348c

📥 Commits

Reviewing files that changed from the base of the PR and between edf63e8 and c5b95a4.

📒 Files selected for processing (3)

• tensorrt_llm/scaffolding/controller.py
• tests/unittest/scaffolding/test_scaffolding.py
• tests/unittest/scaffolding/test_worker.py

💤 Files with no reviewable changes (2)

• tests/unittest/scaffolding/test_scaffolding.py
• tests/unittest/scaffolding/test_worker.py

---

📝 Walkthrough

Walkthrough

This PR changes MajorityVoteController.process to assign the selected candidate to tasks[0].output_str instead of tasks[0].result, and removes the _SCAFFOLDING_EXECUTOR_NVBUG skip marker from two test files, re-enabling five previously skipped tests.

Changes

Majority vote output fix and test re-enablement

Layer / File(s)	Summary
Majority vote output assignment tensorrt_llm/scaffolding/controller.py	Assigns the majority-selected value to tasks[0].output_str instead of tasks[0].result.
Re-enable scaffolding tests tests/unittest/scaffolding/test_scaffolding.py	Removes the pytest import, the _SCAFFOLDING_EXECUTOR_NVBUG skip-mark definition, and its decorator from four test functions.
Re-enable worker test tests/unittest/scaffolding/test_worker.py	Removes the _SCAFFOLDING_EXECUTOR_NVBUG constant and its decorator from test_trtllm_worker_generation.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Related PRs: None identified.

Suggested labels: test, bug fix

Suggested reviewers: None identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is still the template skeleton and leaves Description and Test Coverage empty.	Add a short issue summary, the fix details, and concrete test coverage; keep the checklist and mark applicable items.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows the required ticket-and-type pattern and clearly states the main scaffolding fix.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[tensorrt-cicd]

PR_Github #57466 [ run ] triggered by Bot. Commit: c5b95a4 Link to invocation

[tensorrt-cicd]

PR_Github #57466 [ run ] completed with state SUCCESS. Commit: c5b95a4
/LLM/main/L0_MergeRequest_PR pipeline #46203 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation