[None][fix] Draft KV cache should not allocate host memory#12756
Open
Shang-Pin wants to merge 1 commit intoNVIDIA:mainfrom
Open
[None][fix] Draft KV cache should not allocate host memory#12756Shang-Pin wants to merge 1 commit intoNVIDIA:mainfrom
Shang-Pin wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change modifies the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
When using one-model speculative decoding with separate draft KV cache (e.g. EAGLE3), the draft cache inherits the target's KvCacheConfig which may have a non-zero host_cache_size. This causes unnecessary host memory allocation for the draft cache. Only the target model should use host offloading since draft tokens are transient and may be rejected during verification. Fix: set host_cache_size=0 on the draft KV cache config before creating the draft KV cache manager. Signed-off-by: Shang-Pin Sheng <shang-pin@tmatehq.com>
79148ba to
2575f4d
Compare
Collaborator
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #42595 [ run ] triggered by Bot. Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using one-model speculative decoding with separate draft KV cache (e.g. EAGLE3), the draft cache inherits the target's KvCacheConfig which may have a non-zero host_cache_size. This causes unnecessary host memory allocation for the draft cache. Only the target model should use host offloading since draft tokens are transient and may be rejected during verification.
Fix: set host_cache_size=0 on the draft KV cache config before creating the draft KV cache manager.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.